Enable Foundation to build against a new libicu #1144
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Swift build system has existing support for building a new version of ICU, via the
--libicu
flag, or by specifying thelibicu=true
andinstall-libicu
targets in a preset.It may be desirable to be able to do this on Linux in order to match the version of ICU used on the OSX platform, for two reasons:
However, the plumbing to make Foundation build against the newly built libicu is missing: it currently picks up the system version, which causes the build to fail with messages such as:
This PR adds the necessary flags to build against the new libicu. I replicated the style of the existing solution for the Dispatch libraries.
This has no prereqs, however changes to the build-script (swiftlang/swift#11266) are required before it will have any effect.