Use PKG_CONFIG for libicu foundation.CFLAGS #722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spevans
force-pushed
the
pr_libicu_pkgconfig
branch
from
ea3c9f7 to
9446caa
Compare
- Mirrors use for foundation.LDFLAGS, allowing libicu to be used if installed in non-default include directory
spevans
force-pushed
the
pr_libicu_pkgconfig
branch
from
9446caa to
c0abd78
Compare
|
@swift-ci please test |
|
We've tested this on Ubuntu 14.04 and 16.04 and verified it allows Foundation to be built against a custom libicu, if wanted. There is no change to current behaviour, by default we continue to link against the system libicu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
used if installed in non-default include directory