Enable Foundation to build against a new libicu #11266
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables Foundation to build against a newly built ICU library, such as when the
--libicu
parameter tobuild-script
is used.It may be desirable to be able to do this on Linux in order to match the version of ICU used on the OSX platform, for two reasons:
The corresponding Foundation change is in: swiftlang/swift-corelibs-foundation#1144
This PR would enable
libicu=true
andinstall-libicu
to be added, for example, to thebuildbot_linux
build preset in the future - however I imagine that those changes, and a method of obtaining a particular version of ICU, probably belong in a separate PR.I have tested this locally on Ubuntu 14.04 and 16.04, having first downloaded ICU 57.1 and unpacked it at the same level as
swift/
,swift-corelibs-foundation/
, etc.