Skip to content

Enable Foundation to build against a new libicu #11266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Enable Foundation to build against a new libicu #11266

wants to merge 1 commit into from

Conversation

djones6
Copy link

@djones6 djones6 commented Jul 31, 2017

This enables Foundation to build against a newly built ICU library, such as when the --libicu parameter to build-script is used.

It may be desirable to be able to do this on Linux in order to match the version of ICU used on the OSX platform, for two reasons:

The corresponding Foundation change is in: swiftlang/swift-corelibs-foundation#1144

This PR would enable libicu=true and install-libicu to be added, for example, to the buildbot_linux build preset in the future - however I imagine that those changes, and a method of obtaining a particular version of ICU, probably belong in a separate PR.

I have tested this locally on Ubuntu 14.04 and 16.04, having first downloaded ICU 57.1 and unpacked it at the same level as swift/, swift-corelibs-foundation/, etc.

@djones6
Copy link
Author

djones6 commented Jul 31, 2017

It turns out, there was an existing PR swiftlang/swift-corelibs-foundation#722 that achieves the same thing in a simpler way, via pkg-config which has already been set up by the build-script.

@djones6 djones6 closed this Jul 31, 2017
@djones6 djones6 deleted the libicu2 branch August 1, 2017 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant