Update NSNumberBridging test for init(exactly:) #1274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A fix in the behavior of FloatingPoint.init(exactly:) means that the NSNumber bridging tests need to be updated.
natecook1000
force-pushed
the
nc-fpexactly
branch
2 times, most recently
from
3547704 to
ba78f63
Compare
|
@swift-ci Please test |
parkera
approved these changes
Oct 17, 2017
|
@parkera These failures should be fixed by swiftlang/swift#11311 (the tests passed for that PR), but I don't want to break the tests here. Is there a delay between changes landing in the stdlib and being used in the CI for this repo? |
|
There is some kind of magic to test and merge changes together but I can't remember the syntax for it. |
|
@parkera Just include a link to the PR from the other repo in the same comment where you ask swift-ci to test. |
|
swiftlang/swift#11311 is still causing test failures. I'm reverting that and this. |
|
Reverting in swiftlang/swift#12497 and #1276. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix in the behavior of FloatingPoint.init(exactly:) means that the NSNumber bridging tests need to be updated. That fix is in swiftlang/swift#11311, this PR replaces #1273.