-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[stdlib] Fix FloatingPoint.init(exactly:) #11311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci Please test |
Build failed |
Build error:
|
@swift-ci Please smoke benchmark |
It looks like this test failure is because bridging from |
@natecook1000 I do believe that there were some patches, at least in swift-corelibs-foundation, addressing the issue of |
Build comment file:Optimized (O)Regression (3)
Improvement (2)
No Changes (322)
Unoptimized (Onone)Regression (4)
Improvement (2)
No Changes (321)
Hardware Overview
|
cc @phausler |
This initializer wasn't actually checking the exact conversion. Corrects the tests as well.
2d575be
to
01383bb
Compare
@swift-ci Please smoke test |
@swift-ci Please smoke test |
Build failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a second test beyond the validation btw that will need to be changed
Build comment file:Optimized (O)Regression (8)
Improvement (3)
No Changes (323)
Unoptimized (Onone)Regression (8)
Improvement (13)
No Changes (313)
Hardware Overview
|
@swift-ci Please smoke test |
Build failed |
Please test with following pull request: @swift-ci Please smoke test Linux platform |
Huzzah! Thanks for addressing this. Looks great to me. |
Please test with following pull request: @swift-ci Please smoke test Linux platform |
This is causing failures on 32-bit iOS simulator and on Linux. I'm reverting it and swiftlang/swift-corelibs-foundation#1274 . |
Reverting in #12497 and swiftlang/swift-corelibs-foundation#1276. |
This reverts commit c9f4df8. It is causing test failures on 32-bit iOS simulator and on Linux.
This initializer wasn't actually checking the exact conversion. Corrects the tests as well.
SR: https://bugs.swift.org/browse/SR-4634