Skip to content

Revert "Update NSNumberBridging test for init(exactly:)" #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2017

Conversation

gparker42
Copy link

@gparker42 gparker42 commented Oct 18, 2017

This reverts #1274. That change parallels swiftlang/swift#11311, but that Swift-side change is causing other test failures.

@gparker42 gparker42 changed the title Revert "Update NSNumberBridging test for init(exactly:)" Revert "Update NSNumberBridging test for init(exactly:) (#1274)" Oct 18, 2017
@gparker42 gparker42 changed the title Revert "Update NSNumberBridging test for init(exactly:) (#1274)" Revert "Update NSNumberBridging test for init(exactly:)" Oct 18, 2017
@pushkarnk
Copy link
Member

@swift-ci please test and merge

@pushkarnk
Copy link
Member

pushkarnk commented Oct 18, 2017

Looks like this needs the Swift side change. Let's try adding the PR link per this comment :)

@pushkarnk
Copy link
Member

swiftlang/swift#12497

@swift-ci please test

@gparker42 gparker42 merged commit 4264eff into master Oct 18, 2017
@gparker42 gparker42 deleted the revert-1274-nc-fpexactly branch October 18, 2017 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants