Skip to content

Locate "arclite" library relative to the Clang in the active Xcode #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Apr 6, 2021

Instead of locating it in the current toolchain that the driver belongs to.
This will match the behaviour in the legacy driver:
https://github.com/apple/swift/blob/main/lib/Driver/DarwinToolChains.cpp#L287

Resolves rdar://76035286

@artemcm artemcm requested review from neonichu, edymtt and nkcsgexi April 6, 2021 17:04
@artemcm
Copy link
Contributor Author

artemcm commented Apr 6, 2021

@swift-ci please test

Instead of current toolchain that the driver belongs to.
This will match the behaviour in the legacy driver:
https://github.com/apple/swift/blob/main/lib/Driver/DarwinToolChains.cpp#L287

Resolves rdar://76035286
@artemcm artemcm force-pushed the ArcLiteXcodeFind branch from f968345 to 02e34c3 Compare April 6, 2021 17:28
@artemcm
Copy link
Contributor Author

artemcm commented Apr 6, 2021

@swift-ci please test

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this! 🙏

@artemcm
Copy link
Contributor Author

artemcm commented Apr 6, 2021

@swift-ci please test

@artemcm artemcm force-pushed the ArcLiteXcodeFind branch from 6cb2ce6 to 7c991a3 Compare April 6, 2021 18:04
@artemcm
Copy link
Contributor Author

artemcm commented Apr 6, 2021

@swift-ci please test

@artemcm artemcm merged commit 24419b4 into swiftlang:main Apr 6, 2021
neonichu added a commit to neonichu/swift-package-manager that referenced this pull request Apr 6, 2021
This reverts commit 5fe380c.

With swiftlang/swift-driver#581 being merged, we can undo this temporary workaround.

rdar://76167831
neonichu added a commit to swiftlang/swift-package-manager that referenced this pull request Apr 7, 2021
This reverts commit 5fe380c.

With swiftlang/swift-driver#581 being merged, we can undo this temporary workaround.

rdar://76167831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants