Skip to content

10.11 minimum deployment target #3384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2021
Merged

10.11 minimum deployment target #3384

merged 1 commit into from
Apr 2, 2021

Conversation

neonichu
Copy link
Contributor

@neonichu neonichu commented Apr 2, 2021

rdar://76035286

@neonichu neonichu force-pushed the 10.11-minimum-deployment-target branch from 0541533 to 393f327 Compare April 2, 2021 21:47
@neonichu
Copy link
Contributor Author

neonichu commented Apr 2, 2021

@swift-ci please smoke test

@gottesmm gottesmm merged commit 5fe380c into swiftlang:main Apr 2, 2021
@gottesmm
Copy link
Contributor

gottesmm commented Apr 2, 2021

Fixing bots

@neonichu neonichu deleted the 10.11-minimum-deployment-target branch April 2, 2021 22:00
@benrimmington benrimmington mentioned this pull request Apr 3, 2021
Closed
@benrimmington
Copy link
Contributor

Created swiftlang/sourcekit-lsp/pull/383 to fix test failures.

e.g. https://ci.swift.org/job/swift-PR-macos/26431/

sourcekit-lsp/Tests/SKSwiftPMWorkspaceTests/SwiftPMWorkspaceTests.swift:121: 
error: -[SKSwiftPMWorkspaceTests.SwiftPMWorkspaceTests testBasicSwiftArgs] : 
failed - pattern ["-target", "x86_64-apple-macosx10.10"] not found in arguments
            [..., "-target", "x86_64-apple-macosx10.11", ...]

sourcekit-lsp/Tests/SKSwiftPMWorkspaceTests/SwiftPMWorkspaceTests.swift:361: 
error: -[SKSwiftPMWorkspaceTests.SwiftPMWorkspaceTests testBasicCXXArgs] : 
failed - pattern ["-target", "x86_64-apple-macosx10.10"] not found in arguments
            [..., "-target", "x86_64-apple-macosx10.11", ...]

neonichu added a commit to neonichu/swift-package-manager that referenced this pull request Apr 6, 2021
@neonichu
Revert "Raise the minimum deployment target to 10.11 (swiftlang#3384)"
fc8eaa8 
This reverts commit 5fe380c.

With swiftlang/swift-driver#581 being merged, we can undo this temporary workaround.

rdar://76167831
neonichu added a commit that referenced this pull request Apr 7, 2021
@neonichu
Revert "Raise the minimum deployment target to 10.11 (#3384)" (#3388)
b94b0bc 
This reverts commit 5fe380c.

With swiftlang/swift-driver#581 being merged, we can undo this temporary workaround.

rdar://76167831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abertelrud abertelrud Awaiting requested review from abertelrud

@friedbunny friedbunny Awaiting requested review from friedbunny

@tomerd tomerd Awaiting requested review from tomerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neonichu @gottesmm @benrimmington