Revert "Raise the minimum deployment target to 10.11 (#3384)" #3388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5fe380c. With swiftlang/swift-driver#581 being merged, we can undo this temporary workaround. rdar://76167831
|
@benlangmuir I think this will mean SourceKit-LSP tests need to change again, I can open a PR for that. I'm assuming if we actually run the full smoke tests, this will be uncovered as a failure, right? |
|
@swift-ci please smoke test |
|
@neonichu I think sourcekit-lsp will be fine this time, because I updated our tests to use |
tomerd
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5fe380c.
With swiftlang/swift-driver#581 being merged, we can undo this temporary workaround.
rdar://76167831