Skip to content

Normalize 'Swift 6.0' to 'Swift 6' to match formatting of Swift 3, 4, 5. #2328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dempseyatgithub
Copy link
Contributor

In implemented proposals, previous major versions of Swift have used a single number (e.g. 'Swift 5')

All implementation versions appear in the filter interface of the evolution dashboard and should be consistent.

This PR normalizes 'Swift 6.0' to 'Swift 6' to match the proposals of previous years.

The other option would be to revise all the previous proposals to add '.0'. However, the current method has been in use for many years without any negative feedback as to confusion or lack of clarity.

@rjmccall
Copy link
Contributor

rjmccall commented Feb 19, 2024

My inclination would be to change the existing uses to be 4.0, 5.0, etc. That should make it much clearer that we're talking about a tools release rather than a language mode. I'll bring it up with the LSG so we can make a decision.

I suspect we got into the pattern of Swift 3 etc. because all the feature releases got major version bumps for the first few years. That pattern is decisively broken now, though.

@hborla
Copy link
Member

hborla commented Feb 19, 2024

My inclination would be to change the existing uses to be 4.0, 5.0, etc. That should make it much clearer that we're talking about a tools release rather than a language mode. I'll bring it up with the LSG so we can make a decision.

I agree; I deliberately made it Swift 6.0 because that's the naming convention we use in the compiler code base for Swift 5.0, and soon Swift 6.0. People are also extremely confused between compiler version and language version, and while Swift 6.0 vs Swift 6 isn't perfect, it is at least different.

@dempseyatgithub
Copy link
Contributor Author

dempseyatgithub commented Feb 19, 2024

Yes, my comments regarding confusion were regarding its meaning in the filter interface on the evolution dashboard, where it is alongside other versions like 5.1, 5.2, 5.3, etc.

@rjmccall @hborla Please update this PR with the LSM's decision and I'll update this PR to change the other proposals to 3.0, 4.0, and 5.0 (in the likely event that's the decision).

(And then also update the filter list on the proposal dashboard so that those values can be found.)

@rjmccall
Copy link
Contributor

rjmccall commented Feb 21, 2024

Yes, my comments regarding confusion were regarding its meaning in the filter interface on the evolution dashboard, where it is alongside other versions like 5.1, 5.2, 5.3, etc.

@rjmccall @hborla Please update this PR with the LSM's decision and I'll update this PR to change the other proposals to 3.0, 4.0, and 5.0 (in the likely event that's the decision).

(And then also update the filter list on the proposal dashboard so that those values can be found.)

The LSG decided that we'd like to use 6.0 going forward to avoid confusion with Swift language modes. Updating the existing proposals is the right thing to do. Unfortunately, that'll require checking to make sure that the .0 is actually right; if you'd like to take that on, you're welcome to.

I'm not sure how to update the filter list on the dashboard; we don't usually maintain that.

I'll close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants