Skip to content

Add Swift 6.0 to evolutions list filter #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

alexandersandberg
Copy link
Member

Add version 6.0 to the evolution list's implemented filter.

Motivation:

As we have some proposals marked as implemented in Swift 6.0, we should add this version to the evolutions filter as well.

Modifications:

  • Adds 6.0 to the filter

Result:

You can filter the evolutions list by "implemented in Swift 6.0" (currently 8 results).

CleanShot 2024-02-20 at 20 31 56

@alexandersandberg
Copy link
Member Author

@swift-ci please test

@dempseyatgithub
Copy link
Contributor

dempseyatgithub commented Feb 20, 2024

The language group is deciding whether we want to move to using 'X.0' for major releases or stick with 'X'.
(swiftlang/swift-evolution#2328)

I've got PRs lined up to make the change in both places depending on which they decide.

In the interim, it looks very strange and inconsistent in the filter UI to have all previous major versions as '3', '4', '5' and then Swift 6 listed as '6.0'.

We should find out which direction we are going to go within the next couple of days.

@dempseyatgithub
Copy link
Contributor

@alexandersandberg I have a PR up for swift-evolution that implements the Language Steering Group decision. swiftlang/swift-evolution#2335

I also have put up #557 here which updates the past versions to match the new style and adds 6.0.

Sorry for the thrash on this.

@alexandersandberg
Copy link
Member Author

IMO I still see value in merging this PR now instead of having to wait for the other one which is blocked.

@alexandersandberg alexandersandberg enabled auto-merge (squash) February 22, 2024 07:39
Copy link
Contributor

@dempseyatgithub dempseyatgithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was hoping the PR to swift-evolution would be merged quickly to avoid the inconsistency in the major number versioning in the filter interface.

But it's probably better to have the functionality to filter for the next release even with the version number inconsistency in the interim.

@alexandersandberg alexandersandberg merged commit c812715 into main Feb 22, 2024
@alexandersandberg alexandersandberg deleted the alexandersandberg/swift-evolution-6.0 branch February 22, 2024 10:56
cthielen pushed a commit to Joannis/swift-org-website that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants