Skip to content

Normalize implementation versions for past major versions to match Swift 6.0 #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dempseyatgithub
Copy link
Contributor

@dempseyatgithub dempseyatgithub commented Feb 21, 2024

This PR normalizes the implementation versions for past major versions to match the LSG decision to use '6.0' for the upcoming release, to differentiate from Swift language modes.

I went back to original release announcement blog posts which list proposals implemented to verify that these proposals were part of the appropriate '.0' release.

Although a large number of files change, the changes are all one of the following:
(Swift 3) -> (Swift 3.0)
(Swift 4) -> (Swift 4.0)
(Swift 5) -> (Swift 5.0)

This change will make the version filter interface on the Swift Evolution dashboard consistent, instead of mixing major release versions with and without a '.0'.

I have put up a PR for swift.org to update the list of filters. swiftlang/swift-org-website#557

From @rjmccall in #2328:

The LSG decided that we'd like to use 6.0 going forward to avoid confusion with Swift language modes. Updating the existing proposals is the right thing to do. Unfortunately, that'll require checking to make sure that the .0 is actually right; if you'd like to take that on, you're welcome to.

I'm not sure how to update the filter list on the dashboard; we don't usually maintain that.

@dempseyatgithub dempseyatgithub changed the title Normalize implementation versions for past major versions by adding '.0' Normalize implementation versions for past major versions to match Swift 6.0 Feb 21, 2024
@rjmccall
Copy link
Contributor

Thanks! I really appreciate you going through all of these.

@rjmccall rjmccall merged commit 09058c1 into swiftlang:main Feb 22, 2024
@dempseyatgithub dempseyatgithub deleted the normalize-implementation-versions-for-past-major-releases branch February 23, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants