Skip to content

Handle pattern as editor placeholder #2150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2023
Merged

Handle pattern as editor placeholder #2150

merged 2 commits into from
Sep 7, 2023

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Sep 4, 2023 •
edited
Loading

Fixes #2147
Fixes #2156

@kimdv kimdv requested a review from ahoppen as a code owner September 4, 2023 18:45
kimdv
kimdv commented Sep 4, 2023
View reviewed changes
ahoppen
ahoppen reviewed Sep 5, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of creating an ExpressionPatternSyntax that contains a EditorPlaceholderExprSyntax, I would prefer to introduce a EditorPlaceholderPatternSyntax type that we can use here.

@kimdv kimdv mentioned this pull request Sep 5, 2023
Closed
@kimdv kimdv force-pushed the kimdv/2147-sometimes-the-placeholder-is-identified-as-identifierpattern branch 3 times, most recently from 1283d69 to ca50449 Compare September 7, 2023 19:33
@kimdv kimdv requested a review from ahoppen September 7, 2023 19:33
ahoppen
ahoppen reviewed Sep 7, 2023
View reviewed changes
@kimdv kimdv force-pushed the kimdv/2147-sometimes-the-placeholder-is-identified-as-identifierpattern branch from ca50449 to 6d507ec Compare September 7, 2023 20:16
@kimdv kimdv requested a review from ahoppen September 7, 2023 20:16
@kimdv
Copy link
Contributor Author

kimdv commented Sep 7, 2023

@swift-ci please test

@kimdv kimdv enabled auto-merge September 7, 2023 20:22
@kimdv kimdv merged commit 7215983 into swiftlang:main Sep 7, 2023
@kimdv kimdv deleted the kimdv/2147-sometimes-the-placeholder-is-identified-as-identifierpattern branch September 7, 2023 23:37
@ahoppen ahoppen mentioned this pull request Sep 12, 2023
Closed
This was referenced Sep 13, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support parsing of editor placeholders in type positions Sometimes the placeholder is identified as IdentifierPattern
2 participants
@kimdv @ahoppen