Add token syntax editor placeholder #2186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
force-pushed
the
kimdv/add-token-syntax-editor-placeholder
branch
from
ae3d6ce to
6ebf0d2
Compare
ahoppen
approved these changes
Sep 13, 2023
kimdv
force-pushed
the
kimdv/add-token-syntax-editor-placeholder
branch
from
6ebf0d2 to
0178ef2
Compare
|
@ahoppen added more test cases. |
kimdv
commented
Sep 14, 2023
ahoppen
reviewed
Sep 14, 2023
|
This seems like the most reasonable route to me Is the plan to remove EditorPlaceholderExprSyntax + EditorPlaceholderDeclSyntax in a later PR? Would involve some small fixes to the expansion refactoring, but nothing major. |
Yes I would like to keep it in a separate PR |
kimdv
force-pushed
the
kimdv/add-token-syntax-editor-placeholder
branch
from
0178ef2 to
19d6393
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2147
Fixes #2156
Fixes #2178
We try again after #2183
I've added the test cases from #2150.