Skip to content

Revert "Handle pattern as editor placeholder" #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Sep 13, 2023

Reverts #2150

Part of #2178

@kimdv kimdv requested a review from ahoppen as a code owner September 13, 2023 06:21
@kimdv
Copy link
Contributor Author

kimdv commented Sep 13, 2023

@swift-ci please test

@ahoppen
Copy link
Member

ahoppen commented Sep 13, 2023

@swift-ci Please test macOS

@kimdv kimdv merged commit 0bd5eef into main Sep 13, 2023
@kimdv kimdv deleted the revert-2150-kimdv/2147-sometimes-the-placeholder-is-identified-as-identifierpattern branch September 13, 2023 18:17
@ahoppen
Copy link
Member

ahoppen commented Oct 7, 2023

@kimdv Could you cherry-pick this to release/5.10? I just noticed that #2150 made it into release/5.10 but this PR didn’t, which means that currently release/5.10 has EditorPlaceholderPatternSyntax.

kimdv added a commit to kimdv/swift-syntax that referenced this pull request Oct 8, 2023
…ometimes-the-placeholder-is-identified-as-identifierpattern

Revert "Handle pattern as editor placeholder"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants