Upgrade some deprecation warnings from Swift 3 to errors in Swift 4. #10908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of rdar://problem/28961650 .
Part of rdar://problem/28961650 .
Part of rdar://problem/28961650 .
…wift 4 error. Part of rdar://problem/28961650 .
…errors. Part of rdar://problem/28961650 .
…rrors in Swift 4.0. Fixes rdar://problem/28961650 .
|
@swift-ci Please smoke test |
|
@swift-ci Please Test Source Compatibility |
|
LGTM |
rintaro
added a commit
to rintaro/swift
that referenced
this pull request
Jul 6, 2018
Several diagnostics were warning in Swift3, but errors in Swift4+ Essentially a revert of swiftlang#10908
rintaro
added a commit
to rintaro/swift
that referenced
this pull request
Jul 7, 2018
Several diagnostics were warnings in Swift3, but errors in Swift4+ Related: swiftlang#10908
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://problem/28961650 .
Individual commits for relatively easy reverting, if necessary.