Skip to content

SR-8649: Range types conform to Codable #19532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 14, 2019
Merged

SR-8649: Range types conform to Codable #19532

merged 8 commits into from
Jan 14, 2019

Conversation

dlbuckley
Copy link
Contributor

@dlbuckley dlbuckley commented Sep 25, 2018 •
edited
Loading

Overview

Conform Range, ClosedRange, PartialRangeUpTo, PartialRangeThrough and PartialRangeFrom to Codable.

Bug Report

SR-8649

Forum Thread

Range conform to Codable

Proposal Amendment PR

Swift Evolution PR #915

xwu
xwu reviewed Sep 25, 2018
View reviewed changes
Copy link
Collaborator

@xwu xwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additions! Some brief comments below.

xwu
xwu reviewed Sep 25, 2018
View reviewed changes
@xwu
Copy link
Collaborator

xwu commented Sep 25, 2018

@swift-ci please smoke test

@jrose-apple jrose-apple added the swift evolution pending discussion Flag → feature: A feature that has a Swift evolution proposal currently in review label Sep 25, 2018
@dlbuckley dlbuckley mentioned this pull request Sep 26, 2018
Closed
parkera
parkera reviewed Sep 26, 2018
View reviewed changes
@parkera
Copy link
Contributor

parkera commented Oct 22, 2018

Where did we end up on this one?

@dlbuckley
Copy link
Contributor Author

@parkera Sorry, life got in the way with making the required changes to this PR. I will make the required changes today and try to add in the tests for this (but it's still something I need to investigate).

@parkera
Copy link
Contributor

parkera commented Oct 29, 2018

Awesome, thanks!

@dlbuckley
Copy link
Contributor Author

@parkera I've made the changes and added the tests in what I'm assuming to be the right place.

@parkera
Copy link
Contributor

parkera commented Nov 5, 2018

Thanks @dlbuckley, this looks good to me.

nsalmoria
nsalmoria reviewed Nov 8, 2018
View reviewed changes
moiseev
moiseev reviewed Nov 29, 2018
View reviewed changes
@moiseev
Copy link
Contributor

moiseev commented Dec 13, 2018

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 6ef7cca

@moiseev
Copy link
Contributor

moiseev commented Dec 14, 2018

@swift-ci Please test Linux platform

@moiseev
Copy link
Contributor

moiseev commented Dec 19, 2018

@swift-ci Please Test Source Compatibility

@jrose-apple jrose-apple mentioned this pull request Jan 9, 2019
Closed
@moiseev moiseev added swift evolution approved Flag → feature: A feature that was approved through the Swift evolution process and removed swift evolution pending discussion Flag → feature: A feature that has a Swift evolution proposal currently in review labels Jan 14, 2019
@moiseev moiseev merged commit 3b6c6cc into swiftlang:master Jan 14, 2019
@moiseev moiseev mentioned this pull request Jan 14, 2019
Merged
@dlbuckley dlbuckley mentioned this pull request Jan 16, 2019
Merged
@benrimmington benrimmington mentioned this pull request Jan 22, 2020
Closed
@swift-ci swift-ci mentioned this pull request Sep 25, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xwu xwu xwu left review comments

@moiseev moiseev moiseev left review comments

@parkera parkera parkera left review comments

@nsalmoria nsalmoria nsalmoria left review comments

Assignees
No one assigned
Labels
swift evolution approved Flag → feature: A feature that was approved through the Swift evolution process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dlbuckley @xwu @parkera @moiseev @swift-ci @nsalmoria @jrose-apple