[5.0] Implement SE-0239: Add Codable conformance to Range types #21857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@airspeedswift @moiseev ❤️ ❤️ ❤️ |
dlbuckley
reviewed
Jan 15, 2019
| @@ -1767,6 +1767,40 @@ extension Array : Decodable where Element : Decodable { | |||
| } | |||
| } | |||
|
|
|||
| extension ContiguousArray : Encodable where Element : Encodable { | |||
There was a problem hiding this comment.
Shouldn't there be some tests for the ContiguousArray extensions?
There was a problem hiding this comment.
Yes, there should. This is being discussed in the comments to
#20715. I'll update the PR once that's done.
airspeedswift
approved these changes
Jan 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes work by @dlbuckley and @anayini from the following PRs: