-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[SR-7076] Make ContiguousArray Codable #20715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Implements Encodable and Decodable for ContiguousArray.
Trying to run tests locally as well, but having some build issues...might be because I'm on 10.14... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A formatting point: please use two spaces for indents in this file (and throughout the stdlib).
@xwu - Thank you for the quick feedback! Looks like I applied the fix then rebased onto the upstream where the |
@xwu - Are you able to trigger the tests? |
Sure, but this PR needs to have some tests first before that'd be meaningful, no? |
@xwu - Yeah figured still made sense to run the smoke tests. I looked around a bit and couldn't find the spot where |
@airspeedswift - Do we still want to move forward with this or shall I close? |
Post-break ping for @airspeedswift and maybe @lorentey. |
@swift-ci Please test |
@anayini thanks for implementing this. Do you mind adding a simple test as a follow-up PR? |
@moiseev can do - can you help point me toward a similar |
@anayini A simple test would be similar to the existing Locale and TimeZone tests. You could test The contents of the TestCodable class and tests dictionary are arranged alphabetically. |
@anayini you can see the Codable tests that I've added for the Range conformance in The instructions to run the tests can be found here. I was using a command like |
Thanks @dlbuckley @benrimmington! Will try to get to it this weekend! |
Implements Encodable and Decodable for ContiguousArray.
Resolves SR-7076.