Update Swift:master to work with new stable re-branch from swift-5.1-branch #22699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM r340675 added a new HermitCore OS type to triples, which broke the Swift build because it is using -Werror,-Wswitch and the new value was not handled in swift::getPlatformNameForTriple
The getLocStart API is deprecated and slated for removal from LLVM very soon. Switch to use getBeginLoc instead. I did not see any uses of the corresponding getLocEnd API.
It's default-off, but the harness passes -Weverything. We should consider whether we should change the print-as-objc output. rdar://44228136
We need a trailing space after the warning options to separate them from the following arguments. rdar://problem/44228136
Update swift's usage of clang::vfs which has been hoisted into LLVM.
The default "[options] <inputs>" text is now up to the caller to provide.
The code in TimerGroup::printJSONValue asserts that the name does not need to be quoted. Perhaps we can get this fixed, but for now at least, rename a Timer that has a forward slash in its name.
TerminatorInst has been removed and been made into a regular Instruction. Use the `isTerminator` function instead of the dyn_cast.
`ObjC1` has been removed from clang. Use `ObjC` to detect if Objective-C language support is enabled.
Update for API changes in clang SVN r345605.
DW_TAG_subprogram has its own flag word now. Adjust building the debug info.
…20804) We previously weren't able to import something properly, but now it's working because of some change in Clang. Let's take it! rdar://problem/46263312
Check for the DISPFlagDefinition flag instead of "isDefinition: true".
The main different here is that VFS moved from clang to llvm.
CodeGenOptions.h was moved from Frontend to Basic.
The constructor for `DeclRefExpr` now takes a `Context` parameter to avoid the call to `getASTContext`. Adjust the invocation accordingly.
We used to represent these just as normal LLVM functions, e.x.: declare objc_object* @objc_retain(objc_object*) declare void @objc_release(objc_object*) Recently, special objc intrinsics were added to LLVM. This pass updates these small (old) passes to use the new intrinsics. This turned out to not be too difficult since we never create these instructions. We only analyze them, move them, and delete them. rdar://47852297
The current radar tracking this disabled test is rdar://problem/47777473 See also the similar change on master-next in #22484
The expected output needs to be adjusted for differing optimizer behavior. Tracked by rdar://problem/48056043
The optimizer decided to move casts around. rdar://48056043
This matches the change in upstream LLDB. I've also aligned the invocations to improve the readability and make it clear that they're separate commands executed after each other. (cherry picked from commit 5b1d826)
…type The issue was fixed in #19167 so we no longer need to disable this warning. rdar://problem/47777548
|
macOS Toolchain Install command |
|
LLDB test failures /cc @fredriss https://ci.swift.org/job/swift-PR-Linux/11151/ |
|
@dcci was going to look into the Linux failures |
|
!!! Couldn't read commit file !!! |
|
Build failed before running benchmark. |
|
Build failed before running benchmark. |
|
@bob-wilson failed to build in benchmark job |
|
I looked at this with Mishal. The benchmark is building master and missing the changes from the Swift PR. |
|
Linux LLDB failures should be fixed by apple/swift-lldb#1310. You might want to update the LLDB PR |
|
Build failed |
|
Build failed |
|
Build failed |
|
@dcci @fredriss we are almost there! https://ci.swift.org/job/swift-PR-Linux/11173/ |
|
@shahmishal you can give it another try, I just merged something new. |
|
Looks good, we can merge this tomorrow morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using this pull request to verify the re-branch of the stable from swift-5.1-branch.
https://forums.swift.org/t/updating-stable-branch-later-next-week-feb-2019/20288