Skip to content

Merge tag 'DEVELOPMENT-SNAPSHOT-2019-05-15-a' to 'tensorflow' #24887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 554 commits into from
May 18, 2019

Conversation

rxwei
Copy link
Contributor

@rxwei rxwei commented May 18, 2019

No description provided.

swift-ci and others added 30 commits May 9, 2019 14:52
…ction thunks.

The machinery assumes that it will always have a +1 value. I am attempting to do
the minimal fix here for cherry-picking purposes.

There isn't a test case with this commit since the immutable address verifier
(in the next commit) verifies that this is done correctly. The specific test
that will trip is vtable_thunks_reabstraction.swift.

rdar://50212579
Add a Diagnostic for .init calls which should be transformed into assignments (SR-10297)
[test/CMake] Add the `swift-test-stdlib-*` test dependency under the same conditions as `swift-reflection-test*`
This defers diagnosis until a stage where #if conditions have definitely been evaluated, at the cost of a slightly more complex implementation. We’ll gain some of that complexity back in a subsequent refactoring. Fixes SR-9937.
Now that we manipulate the argument list to correct strange interpolations in Sema, we can parse interpolations directly as argument lists, simplifying the parser.

By itself, this refactoring causes a code completion regression; a subsequent commit will fix that.
This change permits UnresolvedDotExpr to have both a name and a base that are implicit, but a valid DotLoc, and to treat that DotLoc as the node’s location. It then changes the generation of string interpolation code so that `$stringInterpolation.appendInterpolation` references have a DotLoc corresponding to the backslash in the string literal.

This makes it possible for `ExprContextAnalyzer` in IDE to correctly detect when you are code-completing in a string interpolation and treat it as an `appendInterpolation` call.
Fixes an undefined behaviour sanitizer bug.

<rdar://problem/50641097>
stubs: configure flags based on SDK target
[cmake] Ensure swiftReflection is built for tools
…-module

[Serialization] Support Swift only system module
[AliasAnalysis] Check for nullptr before dereferencing.
Adjust the preprocessor macros to get correct DLL Storage for imported
functions.  This should help identify cases of incorrect linkage to
msvcrt/ucrt.
Sema / Test: Fix misplaced fix-it for .init calls on instances
…ttrs

Update LibraryEvolution.rst for new attribute names and @_alwaysEmitIntoClient
XFAIL ParsableInterface/verify_all_overlays.py
…meters when we have a copy of the underlying value.

Otherwise, we may get use-after-frees as in the added test.

rdar://50609145
At some point it might be useful to be able to use an appropriate
explosion schema to explode payloads but currently the code that
handles this is unused. There are lots of different ways we might
add this functionality in the future and it isn't clear that the
existing code will be the best way to use explosion schemas in the
future.

For now remove this dead code so that its presence doesn't obscure
the code that is actually in use.
This allows _swift_getClassOfAllocated to use a constant instead of loading from a global, and allows swift_isaMask to be computed without a static initializer. Debug builds verify that the #define matches the value from libobjc.

rdar://problem/22375602 rdar://problem/46385113
GSB: Lazy requirement signature
…oblems

build: correct flags for Windows build
compnerd and others added 19 commits May 15, 2019 19:12
Driver: use `-Xlinker` rather than `-Wl` (NFC)
When backward deploying to an OS that may not have these entry points, weak-link them so that they
can be used conditionally in availability contexts that check for them.

rdar://problem/50731151
api-digester: avoid looking up node update table to collect renamed declarations. NFC
[TypeChecker] Simplify for ... in ... type checking
IRGen: Weak-link opaque type entry points.
tests: disable check_class_for_archiving checks for older OSes
Fix response file support for batch jobs.
…4800)

I thought it would be useful to allow some uses of a module to be
'@_implementationOnly' and others to not be in case someone wanted to
change from one to the other gradually, but it turns out that if
you're trying to /make/ an import implementation-only, you want to
know everywhere you used it.

rdar://problem/50748157
Add AccessEnforcementOpts fast paths.
…24629)

The logic I had here checked whether an extension used an
implementation-only type whenever there was a declaration within that
extension that needed checking...but unfortunately that included not
just PatternBindingDecls (whose access is filtered at a later step)
but things like IfConfigDecls (#if). Change this to only check
signatures of extensions with ABI-public members, something that is
tested once when visiting an ExtensionDecl.

Additionally, skip AccessorDecls entirely, since they'll be tested
as part of the corresponding subscript or var. This saves a duplicate
diagnostic.

rdar://problem/50541589
# Conflicts:
#	README.md
#	include/swift/Serialization/ModuleFormat.h
#	lib/AST/Parameter.cpp
#	lib/AST/Type.cpp
#	lib/IRGen/IRGenModule.cpp
#	lib/SIL/SILType.cpp
#	lib/Sema/LookupVisibleDecls.cpp
#	lib/Sema/TypeCheckAttr.cpp
#	test/Syntax/Outputs/round_trip_parse_gen.swift.withkinds
#	test/Syntax/round_trip_parse_gen.swift
#	test/stdlib/ErrorBridgedStatic.swift
#	tools/SourceKit/cmake/modules/AddSwiftSourceKit.cmake
#	utils/gyb_syntax_support/NodeSerializationCodes.py
…erge

# Conflicts:
#	lib/Sema/TypeCheckAttr.cpp
#	utils/update_checkout/update-checkout-config.json
This is because we incorrectly called `setAdjointBuffer` on `seed`. Adjoint buffers are expected to be mutable, but indirect arguments are an exception. We should create a buffer copy instead.
@rxwei rxwei changed the title Merge tag 'DEVELOPMENT-SNAPSHOT-2019-05-15-a' to tensor Merge tag 'DEVELOPMENT-SNAPSHOT-2019-05-15-a' to 'tensorflow' May 18, 2019
@rxwei
Copy link
Contributor Author

rxwei commented May 18, 2019

@swift-ci please clean test tensorflow

1 similar comment
@rxwei
Copy link
Contributor Author

rxwei commented May 18, 2019

@swift-ci please clean test tensorflow

@rxwei
Copy link
Contributor Author

rxwei commented May 18, 2019

@swift-ci please clean test tensorflow

3 similar comments
@rxwei
Copy link
Contributor Author

rxwei commented May 18, 2019

@swift-ci please clean test tensorflow

@rxwei
Copy link
Contributor Author

rxwei commented May 18, 2019

@swift-ci please clean test tensorflow

@rxwei
Copy link
Contributor Author

rxwei commented May 18, 2019

@swift-ci please clean test tensorflow

@rxwei
Copy link
Contributor Author

rxwei commented May 18, 2019

Verified that all tests pass locally. Merging.

@rxwei rxwei merged commit ebf21f8 into tensorflow May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.