Skip to content

[SyntaxParse] Fix memory leaks #26937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2019
Merged

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Aug 29, 2019

There were a few places discarding recorded syntax:

  • #<code-complete> at top-level (this should be parsed as UnknownDecl).
  • typealias decl with inheritance clause in protocol decl.

(This is not related to GSoC project)

There were a few places discarding recorded syntax:
- '#<code-complete>' at top-level (this should be parsed as UnknownDecl).
- 'typealias' decl with inheritance clause in protocol decl.
@rintaro rintaro requested a review from nkcsgexi August 29, 2019 20:20
@rintaro
Copy link
Member Author

rintaro commented Aug 29, 2019

@swift-ci Please smoke test

@rintaro
Copy link
Member Author

rintaro commented Aug 29, 2019

@swift-ci Please smoke test macOS

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the detailed clarification.

@rintaro rintaro merged commit e49401b into swiftlang:master Aug 29, 2019
CodaFi added a commit to CodaFi/swift that referenced this pull request Sep 16, 2019
…eakfix"

This reverts commit e49401b, reversing
changes made to bd222ad.
Catfish-Man added a commit that referenced this pull request Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants