[SyntaxParse] Prevent memory leak in Syntax parsing #27132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can easily detect 'ParsedSyntaxNode' leaking. When it's moved, the original node become "null" node. In the destructor of 'ParsedSyntaxNode', assert the node is not "recorded" node.
Add SyntaxParseActions::discardRecordedNode() as a workaround for memory leak during syntax parsing migration.
|
@swift-ci Please smoke test |
|
@swift-ci Please Sourcekit Stress test |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS |
|
@rintaro this may have broken the Windows builds: |
compnerd
added a commit
to compnerd/apple-swift
that referenced
this pull request
Sep 14, 2019
The type deduction here will copy the returned ParsedTypeSyntax which is no longer copy constructible. Use a reference to hold the result instead which should fix the build on Windows. The returned value of the `popToken` returns a `ParsedTokenSyntax` which is no longer copy constructible. Explicitly move the value.
compnerd
added a commit
that referenced
this pull request
Sep 14, 2019
Parse: repair build after #27132
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParsedRawSyntaxNodeholds opaque pointervoid *pointer for "recorded" node. The parser doesn't know how the memory is managed. When anyParsedRawSyntaxNodeholding "recorded" node is discarded, that leaks because the parser doesn't know how to release it.In this patch, to prevent that kind of leaking, make
ParsedRawSyntaxNodemove-only, nullify the original node when moved, assert the it does not hold recorded node in the destructor.