Skip to content

Revert #26937, #27190, and #27132 #27203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 16, 2019
Merged

Revert #26937, #27190, and #27132 #27203

merged 3 commits into from
Sep 16, 2019

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Sep 16, 2019

Changes in the libSyntax parser seem to have caused parsing the standard library to break in Debug(Asserts) builds. Revert this patchset.

Sorry y'all.

@rintaro @compnerd

@CodaFi
Revert "Merge pull request swiftlang#26937 from rintaro/syntaxparse-l…
362b219 
…eakfix"

This reverts commit e49401b, reversing
changes made to bd222ad.
@CodaFi
Revert "Merge pull request swiftlang#27190 from compnerd/27132"
6dc63e2 
This reverts commit 4838791, reversing
changes made to 4c3f044.
@CodaFi
Revert "Merge pull request swiftlang#27132 from rintaro/syntaxparse-p…
d8aaf29 
…arsedrawsyntax-moveonly"

This reverts commit e675c49, reversing
changes made to 73315ba.
@CodaFi
Copy link
Contributor Author

CodaFi commented Sep 16, 2019

@swift-ci please test

@CodaFi
Copy link
Contributor Author

CodaFi commented Sep 16, 2019 •
edited
Loading

@rintaro I think the moveonly-fication here spawned a wild pointer but the stack is smashed pretty hard so I can't say much else for sure. It would definitely be worth spinning up an ASAN+UBSan build to investigate.

Put a breakpoint down in SyntaxParsingContext::popIf.

@Catfish-Man Catfish-Man merged commit 387d2a9 into swiftlang:master Sep 16, 2019
@CodaFi CodaFi deleted the movin-on-up branch September 16, 2019 22:42
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - d8aaf29

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - d8aaf29

rintaro added a commit to rintaro/swift that referenced this pull request Sep 18, 2019
@rintaro
Revert "Merge pull request swiftlang#27203 from CodaFi/movin-on-up"
9f642f0 
This reverts commit 387d2a9, reversing
changes made to bf1ab6c.
@rintaro rintaro mentioned this pull request Sep 18, 2019
Merged
@dan-zheng dan-zheng mentioned this pull request Sep 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CodaFi @swift-ci @Catfish-Man