[SIL] Extracted instruction methods from SILCombiner. #27042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please ASAN test |
|
Build failed |
nate-chandler
force-pushed
the
extract-instruction-modifying-functionality
branch
from
3cbf676 to
06c7516
Compare
|
@swift-ci please test |
|
@swift-ci please ASAN test |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please ASAN test |
nate-chandler
force-pushed
the
extract-instruction-modifying-functionality
branch
from
06c7516 to
5ed3767
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
Build failed |
nate-chandler
force-pushed
the
extract-instruction-modifying-functionality
branch
2 times, most recently
from
5620553 to
038df57
Compare
|
@swift-ci please test |
|
Build failed |
gottesmm
approved these changes
Sep 6, 2019
nate-chandler
force-pushed
the
extract-instruction-modifying-functionality
branch
from
038df57 to
d00a497
Compare
SILCombiner has a number of conveniences for inserting, replacing, and removing instructions that involve modifying a worklist as part of their behavior. Here, that functionality is added to the SILInstructionWorklist; in a subsequent commit it will be removed from SILCombiner which will then call through to SILInstructionWorklist.
In the previous commit, various methods for adding, replacing, and removing instructions were duplicate from SILCombiner into SILInstructionWorklist. Here, SILCombiner is modified to call through to the methods which were added to SILInstructionWorklist.
Adjusted some variable names.
nate-chandler
force-pushed
the
extract-instruction-modifying-functionality
branch
from
d00a497 to
0dce4da
Compare
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test and merge |
nate-chandler
deleted the
extract-instruction-modifying-functionality
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SILCombinerhas a number of conveniences for inserting, replacing, and removing instructions that involve modifying a worklist as part of their behavior.The conveniences are added to
SILInstructionWorklistin the first commit ("[SIL] Extracted instruction methods from SILCombiner.").In the second commit ("[SILCombiner] Use methods from SILInstructionWorklist."),
SILCombineris modified to call through to the methods which were added toSILInstructionWorklist.In the third commit ("[SIL] Tweaked worklist instruction methods' style."), the methods' style is tweaked slightly.
At the moment there is an extra commit stemming from the PR (#27028) that this is based on.