[SIL] Updated instruction worklist. #27028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
gottesmm
reviewed
Sep 4, 2019
nate-chandler
force-pushed
the
update-instruction-worklist
branch
from
aaf9d8d to
b30798c
Compare
gottesmm
reviewed
Sep 4, 2019
nate-chandler
force-pushed
the
update-instruction-worklist
branch
from
b30798c to
a0313a0
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
atrick
reviewed
Sep 5, 2019
nate-chandler
force-pushed
the
update-instruction-worklist
branch
from
a0313a0 to
150f9a8
Compare
|
@swift-ci please test and merge |
|
@swift-ci please ASAN test |
1 similar comment
|
@swift-ci please ASAN test |
|
@swift-ci please clean ASAN test |
1 similar comment
|
@swift-ci please clean ASAN test |
|
@swift-ci please clean test |
1 similar comment
|
@swift-ci please clean test |
|
@swift-ci please ASAN test |
nate-chandler
force-pushed
the
update-instruction-worklist
branch
from
150f9a8 to
beea86d
Compare
|
@swift-ci please ASAN test |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please ASAN test |
4 similar comments
|
@swift-ci please ASAN test |
|
@swift-ci please ASAN test |
|
@swift-ci please ASAN test |
|
@swift-ci please ASAN test |
|
@swift-ci please ASAN test |
gottesmm
reviewed
Sep 6, 2019
| worklistMap.erase(instruction); | ||
| return instruction; | ||
| SILInstruction *pop_back_val() { | ||
| return worklist.pop_back_val().getValueOr(nullptr); |
There was a problem hiding this comment.
I really like how you are bridging the two APIs here!
gottesmm
reviewed
Sep 6, 2019
gottesmm
reviewed
Sep 6, 2019
nate-chandler
force-pushed
the
update-instruction-worklist
branch
from
beea86d to
1481373
Compare
|
The assertion failure from SmallDenseMap ( https://ci.swift.org/job/swift-PR-osx/15765/console ) look to be fixed in an unlanded LLVM patch: https://reviews.llvm.org/D56455 . |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
- Replaced usage of raw map and vector with the type that wraps the combination (BlotSetVector); that provided a significant deduplication since a sizeable portion of the worklist's implementation was in vector and map management now provided by the BlotSetVector. - Templated over the type of map and vector used by the blot set vector. - Added SmallSILInstructionWorklist where the map and vector are specified to be SmallDenseMap and SmallVector respectively. - Replaced usages of bare ValueBase with usages of SILValue. - Renamed zap to resetChecked. Added a bit of functionality to BlotSetVector, specifically to support SILInstructionWorklist: - Made insert return not just the index that the potentially-inserted item is at on return but additionally whether an insertion occurred, matching the behavior of llvm::DenseMap::insert. - Added a method to reserve capacity in the backing vector and map: BlotSetVector::reserve. - Added a method to free extra storage used by the backing vector and map: BlotSetVector::clear. - Modified SmallBlotSetVector's template parameters so that only a value and size can be specified--that type will always use SmallVector and SmallDenseMap for its superclass' VectorT and MapT template parameters. - Updated variable names.
nate-chandler
force-pushed
the
update-instruction-worklist
branch
from
1481373 to
d2270b9
Compare
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlotSetVector); that provided a significant deduplication since a sizeable portion of the worklist's implementation was in vector and map management now provided by theBlotSetVector.ValueBasewith usages ofSILValue.zaptoresetChecked.Added a bit of functionality to
BlotSetVector, specifically to supportSILInstructionWorklist:insertreturn not just the index that the potentially-inserted item is at on return but additionally whether an insertion occurred, matching the behavior ofllvm::DenseMap::insert.BlotSetVector::reserve.BlotSetVector::clear.llvm::SmallVector.