Skip to content

Update checkout for tensorflow/swift-apis. #28124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dan-zheng
Copy link
Contributor

@dan-zheng dan-zheng commented Nov 7, 2019

tensorflow/swift-apis@1aceb2d

-DCOMPILING_TENSORFLOW_MODULE has been renamed to
-DCOMPILING_TENSORFLOW_STDLIB_MODULE for clarity.

"STDLIB" emphasizes that the flag is relevant for building the Swift stdlib.


Friend PR: tensorflow/swift-apis#546

Copy link
Contributor

@saeta saeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dan-zheng dan-zheng force-pushed the fix-tf-stdlib-compilation branch from 60109cd to 58ed1f5 Compare November 7, 2019 02:31
tensorflow/swift-apis@1aceb2d

`-DCOMPILING_TENSORFLOW_MODULE` has been renamed to
`-DCOMPILING_TENSORFLOW_STDLIB_MODULE` for clarity.

`STDLIB` emphasizes that the flag is relevant for building the Swift stdlib.
@dan-zheng dan-zheng force-pushed the fix-tf-stdlib-compilation branch from 58ed1f5 to 7f1d226 Compare November 7, 2019 04:02
@dan-zheng
Copy link
Contributor Author

@swift-ci Please test tensorflow

@dan-zheng
Copy link
Contributor Author

@swift-ci Please clean test tensorflow

@dan-zheng dan-zheng merged commit ac3cafe into swiftlang:tensorflow Nov 7, 2019
@dan-zheng dan-zheng deleted the fix-tf-stdlib-compilation branch November 7, 2019 19:15
@dan-zheng dan-zheng changed the title [TF] Rename -DCOMPILING_TENSORFLOW_STDLIB_MODULE CMake flag. Update checkout for tensorflow/swift-apis. Nov 7, 2019
@AnthonyLatsis AnthonyLatsis added the update-checkout Area → utils: the `update-checkout` script label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tensorflow This is for "tensorflow" branch PRs. update-checkout Area → utils: the `update-checkout` script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants