-
Notifications
You must be signed in to change notification settings - Fork 137
[Layering]: Create Tensor library & move Random. #540
Conversation
This is the first of a series of changes to implement the [Layering Swift APIs Proposal](https://docs.google.com/document/d/1HO_sMhZJHxlDqw4Pjz4qva2s5yzgwxel-82yoK8O6L4/edit#). This first change creates the new Tensor library and moves the random number utilities over.
@saeta @dan-zheng This PR was merged before making associated changes in apple/swift and so the toolchain won't build anymore. The relevant CMake configurations need to be changed in apple/swift for this change to be compatible. |
Thanks for reporting! Could you please share the exact error you encountered? I'll try to reproduce soon today. |
@eaplatanios Sorry about that! I got the following error; is this what you got as well?
|
I reproduced the error. Fixed in: |
Follow-up to #540 fixing TensorFlow stdlib module compilation. - Rename `Sources/Tensor/Utilities.swift -> Sources/Tensor/TensorUtilities.swift` to fix stdlib compilation error: `filename "Utilities.swift" used twice`. - Add `#if !COMPILING_TENSORFLOW_STDLIB_MODULE` guards gating `import Tensor` declarations so that the TensorFlow module can be built as part of the stdlib. - This will no longer be necessary when TensorFlow is no longer built as part of the stdlib: #488.
@saeta, if this is being done systematically and some order of files are being shifted from tensorflow to tensor and deeplearning, I'd love to help as well ! |
Hi @Shashi456 ! Thanks for volunteering. That would be super helpful. I'm currently thinking through what makes sense to do next. As I come up with a plan, I'll be sure to let you know! :-) (There are some other considerations I'm trying to think through, so it might be a little bit.) Thanks again! -Brennan |
This is the first of a series of changes to implement the Layering Swift APIs
Proposal.
This first change creates the new Tensor library and moves the random number
utilities over.