This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Fix TensorFlow stdlib module compilation. #546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`#if !COMPILING_TENSORFLOW_STDLIB_MODULE` is necessary to gate `import Tensor` declarations so that the TensorFlow module can be built as part of the stdlib. This will no longer be necessary when TensorFlow is no longer built as part of the stdlib: tensorflow#488.
dan-zheng
requested review from
saeta and
eaplatanios
and removed request for
saeta
dan-zheng
changed the title
#if !COMPILING_TENSORFLOW_STDLIB_MODULE.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #540 fixing TensorFlow stdlib module compilation.
Sources/Tensor/Utilities.swift → Sources/Tensor/TensorUtilities.swiftto fix stdlib compilation errors:#if !COMPILING_TENSORFLOW_STDLIB_MODULEguards gatingimport Tensordeclarations so that the TensorFlow module can be built as part of the stdlib.
This will no longer be necessary when TensorFlow is no longer built as part of
the stdlib: #488.
Friend PR: swiftlang/swift#28124