Skip to content

Driver: mark test as XFAIL on windows #28894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2019
Merged

Driver: mark test as XFAIL on windows #28894

merged 1 commit into from
Dec 20, 2019

Conversation

compnerd
Copy link
Member

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

CC: @drodriguez

@compnerd
Copy link
Member Author

@swift-ci please smoke test

@compnerd
Copy link
Member Author

Actually, no, this is wrong, it does work, it is a question of which rm is in use. The one from git actually does work.

@compnerd compnerd closed this Dec 20, 2019
@compnerd compnerd deleted the wunicode branch December 20, 2019 04:14
@compnerd compnerd restored the wunicode branch December 20, 2019 18:37
@compnerd compnerd reopened this Dec 20, 2019
@compnerd
Copy link
Member Author

@swift-ci please smoke test macOS platform

@compnerd
Copy link
Member Author

CC: @shahmishal

@shahmishal shahmishal merged commit 4062012 into swiftlang:master Dec 20, 2019
@drodriguez
Copy link
Contributor

I don't think this is the file that was failing. The failing file was test/Driver/batch_mode_with_supplementary_filelist_unicode.swift and this PR modifies test/Driver/batch_mode_with_supplementary_filelist.swift instead.

@drodriguez
Copy link
Contributor

David opened #28902 and I opened #28905 with possible fixes. I don't have a Windows machine at home to test, so the CI machines are doing the work.

This was referenced Dec 20, 2019
Merged
Merged
@compnerd compnerd deleted the wunicode branch December 20, 2019 21:42
@compnerd compnerd mentioned this pull request Dec 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@compnerd @drodriguez @shahmishal