Skip to content

[MSVC] Evaluate parameters in the right order. #28906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2019
Merged

[MSVC] Evaluate parameters in the right order. #28906

merged 1 commit into from
Dec 20, 2019

Conversation

drodriguez
Copy link
Contributor

Parameter evaluation order is unspecified, and MSVC happens to do it in
the opposite order than Clang.

Move the evaluation of the parameters outside the invocation, so the
order is clear, and the token consuming happens in the right order.

@drodriguez
[MSVC] Evaluate parameters in the right order.
fb30e9e 
Parameter evaluation order is unspecified, and MSVC happens to do it in
the opposite order than Clang.

Move the evaluation of the parameters outside the invocation, so the
order is clear, and the token consuming happens in the right order.
@drodriguez
Copy link
Contributor Author

@swift-ci please clean test Windows platform

@drodriguez drodriguez mentioned this pull request Dec 20, 2019
Closed
xedin
xedin reviewed Dec 20, 2019
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta love C++...

@drodriguez
Copy link
Contributor Author

@swift-ci please smoke test

@drodriguez
Copy link
Contributor Author

drodriguez commented Dec 20, 2019 •
edited
Loading

Windows tests failed as expected:

Unexpected Passing Tests (1):
    Swift(windows-x86_64) :: Driver/batch_mode_with_supplementary_filelist.swift

********************
Failing Tests (1):
    Swift(windows-x86_64) :: Driver/batch_mode_with_supplementary_filelist_unicode.swift

The unexpected successful test is because of #28894, and the failing test and removing the unexpected successful test might happen in #28902.

/cc @compnerd @shahmishal I think we should prefer this one to #28903, but I leave it to your decision.

@compnerd
Copy link
Member

@swift-ci please smoke test

@shahmishal shahmishal merged commit 2101029 into swiftlang:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drodriguez @compnerd @xedin @shahmishal