Skip to content

[Driver, Incremental] Make dummy make-file dependencies path OK for Windows #28902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2019
Merged

[Driver, Incremental] Make dummy make-file dependencies path OK for Windows #28902

merged 1 commit into from
Dec 20, 2019

Conversation

davidungar
Copy link
Contributor

rdar://57824038

@davidungar
Copy link
Contributor Author

@swift-ci please test

@davidungar
Copy link
Contributor Author

@swift-ci please test source compatibility

@davidungar
Copy link
Contributor Author

@drodriguez Might be a fix for Windows

@davidungar
Copy link
Contributor Author

@swift-ci please test windows platform

@drodriguez
Copy link
Contributor

BTW, there's another two errors in the Windows testing right now. You will have to drill into the output to see if this fixes the problem.

In the meantime, I also opened #28905, in case the problem is MSVC dropping a constructor result that's not saved anywhere.

@drodriguez drodriguez mentioned this pull request Dec 20, 2019
Merged
@drodriguez
Copy link
Contributor

@compnerd @shahmishal : it seems that this fixes the problem with the dependencies test. It has the two closure asserts failing, and it also has the unexpected passing tests for Driver/batch_mode_with_supplementary_filelist.swift because of #28894.

Seems that this might be a good candidate for merging, as well as reverting #28894.

@shahmishal
Copy link
Member

Can we pull in the revert in to this PR? (git revert 5ab6c46e556d524bf6bc7224c7e60116099385cb)

@drodriguez drodriguez mentioned this pull request Dec 20, 2019
Merged
@shahmishal shahmishal merged commit 97a5690 into swiftlang:master Dec 20, 2019
@davidungar
Copy link
Contributor Author

davidungar commented Dec 20, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidungar @drodriguez @shahmishal @compnerd