Merge 2020-06-02 into tensorflow #32146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odule. This is important, for example, for linking correctly to the C++ standard library on Windows, which uses `#pragma comment(lib, ...)` in its headers to specify the correct library to link against.
Make the note on needing to adjust `PYTHON_EXECUTABLE` more prominent, and repeat in in the place where that argument actually needs to be adjusted.
…hr). Ubuntu 20.04 LTS is out now; the last version to support 14.04 was Swift 5.1, so it is ok to delete this.
Added note on which edition of Visual Studio to get.
…nbound Objective-C generic for bound ones IRGen does so. So don't assert on this case. rdar://63509292
Previously, whenever name lookup returned two declarations with the same name, we would compute the canonical type of each one as part of the shadowing check. The canonical type calculation is rather expensive for GenericFunctionTypes since it requires constructing a GenericSignatureBuilder to canonicalize type parameters that appear in the function's signature. Instead, let's first shard all declarations that have the same name by their generic signature. If two declarations have the same signature, only then do we proceed to compute their canonical type. Since computing a canonical GenericSignature is cheaper than computing a canonical GenericFunctionType, this should speed up name lookup of heavily-overloaded names, such as operators. Fixes <rdar://problem/56800097>.
Using a SetVector fixes an issue where many source files imported the same SPI group from the same module, the emitted private textual interfaces superfluously repeated the `@_spi` attribute on the import. rdar://problem/63681845
Remove reference to the latest release.
Also remove some ancient logic to detect and ignore requests to use LLD. If people want to explicitly use LLD, they probably have a reason and we shouldn't second guess them.
This code is only used on one side of a if/else branch, so let's just move it inside the `else` block.
The reasons for disabling it appear to now be outdated. Re-enable it, and run it after the entire pipeline has finished to make sure we verify any decls deserialised during SIL/IRGen.
Set the "failed to load" flag on the main module if the stdlib fails to load, as we'll bail without adding any source files to the module.
If a partial module fails to load, the main module may be left without files, so let's set the failed to load bit.
When deserializing, we delay parenting GenericTypeParamDecls until we install the GenericParamList on the parent declaration, using a dummy parent of the ModuleDecl until this happens. However when deserializing GenericTypeParamTypes, we don't necessarily get the opportunity to deserialize the parent, leaving them with the dummy parent. We should probably consider not deserializing GenericTypeParamDecls at all, we currently only do it to preserve the sugar of the name, this could be serialized on the type instead. For now though, adjust the dummy parent to be the SerializedASTFile, and tell the ASTVerifier to skip verification for such generic params.
rdar://63666780
This reverts commit aed0d91.
This information can be derived from whether we're installing the module file into the main module.
Rather than adding a ModuleFile to a parent module and then removing it afterwards if it fails to load, let's wait until we've loaded the file before deciding to add it to the parent module. This then allows us to get rid of `ModuleDecl::removeFile`. In addition, push down the calls to `addFile` into the callers of `loadAST` in preparation for `addFile` being replaced with a one-time-only call to a `setFiles` method.
Start asserting in `ModuleDecl::getFiles` that the module is either non-empty or has failed to load. This ensures that module loading doesn't attempt to query the module's files until the ModuleFile has been installed.
Add a common helper function `VJPEmitter::createTrampolineBasicBlock`. Change `VJPEmitter::buildPullbackValueStructValue` to take an original basic block instead of a terminator instruction.
This test was disabled in SR-12741 due to iphonesimulator-i386 failures. Enabling the test on other platforms is important to prevent regressions.
This cleans up some more `llvm::` leakage in the runtime when built into a static library. With this change we are down to 3 leaking symbols in the static library related to a missed ADT (`StringSwitch`).
Python 2/3 compat: gyb, gyb_sourcekit_support, gyb_syntax_support, li…
…t-marie-kondo Get rid of #includes that do not spark joy
…ce-loc AST: Don't set source location on cloned parameter lists
[ConstraintSystem][NFC] add test cases for argument matching
build: simplify macOS path (NFC)
Add a demangler option to hide the "__C" module name.
ASTPrinter: Add an option to qualify ClangImported types.
[NFC] Pre- increment and decrement where possible
[Index][SR-12903] Index `@objc optional` references
Add a [nonoverridden] kind for SILVTable entries.
…5ab9204bfd4427 [silgen] Create a function level scope when open coding implicit value initializers.
Add a Test Demonstrating Superfluous Cascading Across Module Boundaries
xihui-wu
changed the title
|
@swift-ci Please clean test TensorFlow |
|
@swift-ci Please clean test TensorFlow |
1 similar comment
|
@swift-ci Please clean test TensorFlow |
|
macOS CI failures are expected, the CI machine needs to be upgraded to macOS 10.15. Let's go ahead and merge this PR despite the failures to unblock progress. |
dan-zheng
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.