[Sema] Check protocol conformance availability for member reference and type erasing expressions #41054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rovided by a protocol conformance be sure to check the availability of conformance. Expands conformance availability tests to include test cases covering member references and key paths. Resolves rdar://87795154.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
slavapestov
approved these changes
Jan 28, 2022
Thanks! I'll see what it would take to expand this to cover that expression as well. |
…ons (e.g. `let x: P = S` where S conforms to P). Resolves rdar://83731428.
tshortli
changed the title
|
@swift-ci please smoke test |
tshortli
force-pushed
the
check-protocol-conformance-availability-for-members
branch
from
2040377 to
d575bba
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test macOS |
|
@swift-ci please smoke test macOS |
slavapestov
approved these changes
Feb 1, 2022
tshortli
deleted the
check-protocol-conformance-availability-for-members
branch
beccadax
pushed a commit
to beccadax/swift
that referenced
this pull request
Apr 21, 2022
In swiftlang#41054, we fixed an oversight which caused us to not notice when a user erased a concrete type to an existential using an unavailable conformance. Unfortunately, this is source-breaking and needs to be reduced to a warning in Swift 5 mode unless the user opts in. Fixes rdar://91940820.
beccadax
pushed a commit
to beccadax/swift
that referenced
this pull request
Apr 21, 2022
In swiftlang#41054, we fixed an oversight which caused us to not notice when a user erased a concrete type to an existential using an unavailable conformance. Unfortunately, this is source-breaking and needs to be reduced to a warning in Swift 5 mode unless the user opts in. Fixes rdar://91940820.
beccadax
pushed a commit
to beccadax/swift
that referenced
this pull request
Apr 22, 2022
In swiftlang#41054, we fixed an oversight which caused us to not notice when a user erased a concrete type to an existential using an unavailable conformance. Unfortunately, this is source-breaking and needs to be reduced to a warning in Swift 5 mode unless the user opts in. Fixes rdar://91940820.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diagnose uses of potentially unavailable protocol conformances in member reference expressions (
x.foowherefoois a property ofx) and type erasure expressions (let p: P = SwhereSconforms toP) since unguarded uses of these conformances can cause crashes at runtime.Expands conformance availability tests to include test cases covering member references, key paths, and invocation of functions taking existentials.
Resolves rdar://87795154 and rdar://83731428.