Skip to content

[5.7] Soften new unavailable conformance diagnostics #42540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2022

Conversation

beccadax
Copy link
Contributor

Cherry-picks #42528 to release/5.7:

In #41054, we fixed an oversight which caused us to not notice when a user erased a concrete type to an existential using an unavailable conformance. Unfortunately, this is source-breaking and needs to be reduced to a warning in Swift 5 mode unless the user opts in.

This PR also includes an enhancement to DeclContext dumping that helps when locating imported declarations; I'm not sure this code is actually valid in its present form, and might remove it if it's a problem.

Fixes rdar://91940820.

Becca Royal-Gordon added 2 commits April 21, 2022 11:05
…in DeclContext::dumpContext(). This makes the dumps more usable since these declarations otherwise don’t have usable filenames or line numbers.
In swiftlang#41054, we fixed an oversight which caused us to not notice when a user erased a concrete type to an existential using an unavailable conformance. Unfortunately, this is source-breaking and needs to be reduced to a warning in Swift 5 mode unless the user opts in.

Fixes rdar://91940820.
@beccadax beccadax requested a review from a team as a code owner April 21, 2022 18:09
@beccadax
Copy link
Contributor Author

@swift-ci please test

@beccadax beccadax merged commit 3be5f7c into swiftlang:release/5.7 Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants