Soften new unavailable conformance diagnostics #42528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 21, 2022 01:15
…in DeclContext::dumpContext(). This makes the dumps more usable since these declarations otherwise don’t have usable filenames or line numbers.
In swiftlang#41054, we fixed an oversight which caused us to not notice when a user erased a concrete type to an existential using an unavailable conformance. Unfortunately, this is source-breaking and needs to be reduced to a warning in Swift 5 mode unless the user opts in. Fixes rdar://91940820.
|
@swift-ci smoke test |
tshortli
reviewed
Apr 21, 2022
| @@ -52,3 +52,33 @@ func passAvailableConformance1a(x: HasAvailableConformance1) { | |||
| _ = x.isGalloping | |||
| _ = UsesHorse<HasAvailableConformance1>.self | |||
| } | |||
|
|
|||
| // Explicit unavailability | |||
| public struct HasAvailableConformance2 {} | |||
There was a problem hiding this comment.
Minor: I would find this a bit clearer if it were named HasUnavailableConformance (it looks like the equivalent struct is named that way in conformance_availability.swift).
This was referenced Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #41054, we fixed an oversight which caused us to not notice when a user erased a concrete type to an existential using an unavailable conformance. Unfortunately, this is source-breaking and needs to be reduced to a warning in Swift 5 mode unless the user opts in.
This PR also includes an enhancement to
DeclContextdumping that helps when locating imported declarations; I'm not sure this code is actually valid in its present form, and might remove it if it's a problem.Fixes rdar://91940820.