[ModuleInterface] Print the @_spiOnly attribute in private swiftinterfaces without comments #64260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This attribute was commented out in the private swiftinterface for backwards compatibility with older compilers unaware of the attribute. This scenario shouldn't be a problem anymore and without that attribute some imports can raise errors. Let's print the attribute as it was written in the sources without commenting it out.
|
@swift-ci Please smoke test |
tshortli
approved these changes
Mar 9, 2023
This was referenced Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attribute was commented out in the private swiftinterface for backwards compatibility with older compilers unaware of the attribute. This scenario shouldn't be a problem anymore and without that attribute some imports can raise errors. Let's print the attribute as it was written in the sources without commenting it out.