Skip to content

RSDK-4578: Python SDK Base Properties #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

martha-johnston
Copy link
Contributor

@martha-johnston martha-johnston commented Aug 16, 2023

Update python SDK to include new base property wheel_circumference_meters

Note to reviewers: I am not sure if there's something I have to do to specifically update this PR to use the most recent API changes? I'm seeing some errors which I believe are because it's not referencing the most recent version of API.

Edit: It passed all the checks though so maybe that was just a local issue

@martha-johnston martha-johnston requested a review from a team as a code owner August 16, 2023 21:24
@github-actions
Copy link
Contributor

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base is_moving
board gpio_pin_by_name
camera get_image
encoder get_position
motor is_moving
sensor get_readings
servo get_position
arm get_end_position
gantry get_lengths
gripper is_moving
movement_sensor get_linear_acceleration
input_controller get_controls
audio get_properties
pose_tracker get_poses
power_sensor get_voltage
motion get_pose
vision get_classifications_from_camera

@stuqdog
Copy link
Member

stuqdog commented Aug 17, 2023

@martha-johnston you are correct, it looks like we don't have the latest in yet. I think tests are passing because we don't have any tests that specifically would check for this, but I wouldn't expect a user to have success with it as-is.

@njooma looks like we haven't updated protos in python in a while, are you aware of any changes that need to be implemented before we can do so?

@maximpertsov
Copy link
Contributor

maximpertsov commented Aug 17, 2023

@martha-johnston you are correct, it looks like we don't have the latest in yet. I think tests are passing because we don't have any tests that specifically would check for this, but I wouldn't expect a user to have success with it as-is.

@njooma looks like we haven't updated protos in python in a while, are you aware of any changes that need to be implemented before we can do so?

I pulled in proto changes for typescript recently and saw that the motion service had breaking changes

@njooma
Copy link
Member

njooma commented Aug 18, 2023

@martha-johnston you are correct, it looks like we don't have the latest in yet. I think tests are passing because we don't have any tests that specifically would check for this, but I wouldn't expect a user to have success with it as-is.

@njooma looks like we haven't updated protos in python in a while, are you aware of any changes that need to be implemented before we can do so?

Yup, there are breaking data changes as well. Tagged you @stuqdog and @8ashar to snag the latest data updates: comment

@martha-johnston
Copy link
Contributor Author

Just want to follow up here, is there something I specifically need to do related to these breaking changes in this PR in order to update to the latest proto?

@njooma
Copy link
Member

njooma commented Aug 21, 2023

@martha-johnston I updated the protos. If you rebase from main, you should be able to get all the new protos and accurately test your code.

@martha-johnston
Copy link
Contributor Author

@maximpertsov @cheukt should be good to go for review now! all the protos are updated and tests pass

Copy link
Member

@cheukt cheukt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test for get_properties?

@martha-johnston martha-johnston requested a review from cheukt August 22, 2023 14:48
Copy link
Member

@cheukt cheukt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martha-johnston martha-johnston merged commit fc86a2b into viamrobotics:main Aug 22, 2023
@martha-johnston martha-johnston deleted the rsdk-4578 branch August 22, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants