-
Notifications
You must be signed in to change notification settings - Fork 60
RSDK-4578: Python SDK Base Properties #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
@martha-johnston you are correct, it looks like we don't have the latest in yet. I think tests are passing because we don't have any tests that specifically would check for this, but I wouldn't expect a user to have success with it as-is. @njooma looks like we haven't updated protos in python in a while, are you aware of any changes that need to be implemented before we can do so? |
I pulled in proto changes for typescript recently and saw that the motion service had breaking changes |
Yup, there are breaking data changes as well. Tagged you @stuqdog and @8ashar to snag the latest data updates: comment |
Just want to follow up here, is there something I specifically need to do related to these breaking changes in this PR in order to update to the latest proto? |
@martha-johnston I updated the protos. If you rebase from main, you should be able to get all the new protos and accurately test your code. |
29f36fc
to
3c6b91f
Compare
@maximpertsov @cheukt should be good to go for review now! all the protos are updated and tests pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a test for get_properties?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update python SDK to include new base property
wheel_circumference_meters
Note to reviewers: I am not sure if there's something I have to do to specifically update this PR to use the most recent API changes? I'm seeing some errors which I believe are because it's not referencing the most recent version of API.
Edit: It passed all the checks though so maybe that was just a local issue