Separate core from services #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamoonraja
reviewed
Mar 8, 2019
|
Yeah I noticed that too. I merged in the last branch into this one so I could keep working while that was being reviewed. I’ll look through to make sure nothing unexpected is happening here. |
|
@mamoonraja it looks like Common.cs is in the v3.0.0. Branch already. I’m thinking some end of line differences turned up when I merged the common branch into this branch. |
mamoonraja
approved these changes
Mar 11, 2019
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To be merged after #529
This pull request separates the core from the services. Since Unity does not have a dependency manager, the Core is added to the SDK as a submodule. This is a better solution than having the user download two different git repos.