Skip to content

Support SVG image #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 5, 2021
Merged

Support SVG image #1226

merged 9 commits into from
Apr 5, 2021

Conversation

M-i-k-e-l
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l commented Mar 14, 2021 •
edited
Loading

Description

Support SVG image
I'm not sure about the isSvg check (in Image).
Two typings problems: (1) how do we import the lib's typings (while using try catch) (2) I had to use any as data's type, it's not critical, it's internal for now.

Changelog

Support SVG image

@M-i-k-e-l M-i-k-e-l requested a review from ethanshar March 14, 2021 14:22
@M-i-k-e-l
Merge branch 'master' of https://github.com/wix/react-native-ui-lib i…
336e348 
…nto infra/support-svg-image

* 'master' of https://github.com/wix/react-native-ui-lib:
  Update FeatureHighlight example screen
@M-i-k-e-l
Merge branch 'master' into Infra/support-svg-image
2aa0f13 
* master:
  fix/connent duration prop (#1228)
  Colors - add transparent (#1234)
  fix screen UI (#1230)
  Fix exported Image static types
  Use reanimatedv2 API in our components (#1224)
  Infra/eslint v2 (#1193)
ethanshar
ethanshar reviewed Mar 22, 2021
View reviewed changes
@ethanshar ethanshar linked an issue Mar 30, 2021 that may be closed by this pull request
react-native-svg support #693
Closed
@M-i-k-e-l M-i-k-e-l requested a review from ethanshar April 4, 2021 13:32
@ethanshar ethanshar merged commit b750df6 into master Apr 5, 2021
@M-i-k-e-l M-i-k-e-l mentioned this pull request Apr 7, 2021
Closed
@M-i-k-e-l M-i-k-e-l deleted the Infra/support-svg-image branch October 4, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees

@ethanshar ethanshar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

react-native-svg support
2 participants
@M-i-k-e-l @ethanshar