Skip to content

Feat/new pan view with reanimated 2 #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Aug 10, 2021
Merged

Feat/new pan view with reanimated 2 #1404

merged 26 commits into from
Aug 10, 2021

Conversation

M-i-k-e-l
Copy link
Collaborator

Description

New unified PanView - initial commit to incubator.
TODOs:

  1. Hidden location (where will the view animate to when dismissed) is not calculated on layout --> very long time until onDismiss is called.
  2. Need to add enter animation.

Changelog

New unified PanView - initial commit to incubator.

M-i-k-e-l added 8 commits July 1, 2021 13:13
@M-i-k-e-l
New PanView - somewhat working
b222458
@M-i-k-e-l
Small refactor
12ea702
@M-i-k-e-l
Add worklet
0978cd6
@M-i-k-e-l
Merge branch 'master' into feat/new-pan-view-with-reanimated-2
193fc80 
* master:
  Upgrade eslint-plugin-uilib to version 2.0.09
  Typescript/wizard move to typescript (#1390)
  Feat/hint add props (#1399)
  Separate radioGroup and radioButton to fix their packages (#1388)
  Typescript/connection status bar (#1384)
  Fix typescript migration bug, code should enter here to calcylate tip position also when width is undefined (casting to 0) (#1396)
  Fix an exception with hard coded color rule (#1394)
  Add onChange to dependency array (#1391)
  fix colorPicker ts error
  Update stale.yml
  Typescript/general missing typings (#1389)
  fix hint animation (#1363)
  using renderInput instead renderExpandableInput was left out (#1386)
  DateTimePicker - Implement theme variant prop (#1357)
  Infra/Migrate Incubator.WheelPicker to reanimated 2 (#1379)
  Remove old typings that were migrated to generatedTypes
  Fix Hint export in generatedType/index
  Update react-native-gesture-handler to version 1.10.3
  Fix export of AvatarHelper in src/index.ts (#1376)
  ExampleScreenPresenter - fix typo (#1374)
@M-i-k-e-l
Fix typings
faa0207
@M-i-k-e-l
Do not add GestureHandlerRootView by default
700cb59
@M-i-k-e-l
Move to Incubator
a24f4cf
@M-i-k-e-l
Move to Incubator (2)
35d4d54
@M-i-k-e-l M-i-k-e-l requested a review from ethanshar July 14, 2021 06:47
ethanshar
ethanshar reviewed Jul 21, 2021
View reviewed changes
Copy link
Collaborator

@ethanshar ethanshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great!
Wrote some comments..

@M-i-k-e-l M-i-k-e-l requested a review from ethanshar August 3, 2021 16:14
@M-i-k-e-l
Copy link
Collaborator Author

I did not respond to all the comments, but I'd appreciate it if you can reply to the ones I did 🙏

@ethanshar
Copy link
Collaborator

@M-i-k-e-l
I think you missed some comments in the PR, I mentioned you in relevant places

@M-i-k-e-l
Copy link
Collaborator Author

Added springBack (formerly known as autoReturn); I think all comments are covered.

@ethanshar ethanshar merged commit 78347bc into master Aug 10, 2021
@M-i-k-e-l M-i-k-e-l deleted the feat/new-pan-view-with-reanimated-2 branch October 4, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees

@ethanshar ethanshar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-i-k-e-l @ethanshar