V7_KeyboardAccessoryView - remove 'iOSScrollBehavior' prop #2469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
changed the title
Inbal-Tish
changed the title
M-i-k-e-l
reviewed
Feb 15, 2023
| @@ -72,7 +66,6 @@ class KeyboardAccessoryView extends Component<KeyboardAccessoryViewProps> { | |||
| /** | |||
| * @deprecated Please use KeyboardAccessoryView.scrollBehaviors instead | |||
There was a problem hiding this comment.
Please remove this as well
| @@ -99,12 +92,6 @@ class KeyboardAccessoryView extends Component<KeyboardAccessoryViewProps> { | |||
|
|
|||
| this.registerForKeyboardResignedEvent(); | |||
| this.registerAndroidBackHandler(); | |||
|
|
|||
| if (props.iOSScrollBehavior) { | |||
| LogService.warn(`The 'Keyboard.KeyboardAccessoryView' component's prop 'iOSScrollBehavior' is deprecated. | |||
There was a problem hiding this comment.
LogService can be removed from the imports
There was a problem hiding this comment.
Yes, that was the issue that failed my build... Thanks
M-i-k-e-l
approved these changes
Feb 16, 2023
ethanshar
added a commit
that referenced
this pull request
Feb 16, 2023
* V7/ remove leftToggleHapticTrigger drawer (#2470) * remove leftToggleHapticTrigger * formatting * Fader - FaderPosition enum remove LEFT and RIGHT cases * V7 remove native WheelPicker (#2475) * Remove native WheelPicker * Remove WheelPickerDialog * Remove WheelPickerPackage leftovers * Remove PickerPackage(s) * Missed one * Remove 'style' prop from ColorPicker (#2480) * v7_Picker (#2478) * Migrate picker component * Remove commented code * Incubator Toast zIndex set to 100 as default when using Android (#2477) * V7 primary colors (#2476) * remove Colors.primary * remove themeColors * update test * TabController - remove 'selectedIndex' prop (#2481) * remove contentOnRight prop (#2473) * V7 dark shadows (#2472) * remove dark shadow presets * update screen * formatting * deprecate imageSource of Avatar (#2471) * KeyboardAwareListView - remove component (#2474) * Remove some Skeleton props (#2482) * Move moment to be optional dependency (#2485) * V7_DateTimePicker (#2487) * Migrate ChipsInput to Incubator ChipsInput (#2483) * Migrate ChipsInput to Incubator ChipsInput * removed old ChipsInput componenet * Moved Incubator ChipsInput to components, fixed review notes * V7/ ThemeManager (#2484) * remove old theme keys and themeManager getters * remove primaryColor from theme * revert chipsInput change --------- Co-authored-by: Ethan Sharabi <[email protected]> * TabBar - remove component (#2467) * v7_TextField (#2468) * Enable text field migration * Ignore/fix TS errors * Move incubator TextField example screen to be the official screen * Remove centered prop from migration since it is supported * Remove transformer from migration list cause it is supported as formatter * V7_KeyboardAccessoryView - remove 'iOSScrollBehavior' prop (#2469) * KeyboardAccessoryView - remove 'iOSScrollBehavior' prop and 'iosScrollBehaviors' enum * fix pr comments * V7/ update colors docs (#2488) * update colors docs * improve docs * add missing comma * WheelPicker - move from incubator (#2486) * Press is actually sync (#2459) * Tests/Add testID to AnimatedScanner (#2458) * add testID to AnimatedScanner * update API * Update src/components/animatedScanner/index.js fix lint --------- Co-authored-by: Inbal Tish <[email protected]> * Re-export WheelPicker from Incubator and add a TODO to delete * V7 - Upgrade typescript to latest version 4.9.5 and fix errors (#2490) * Docs - adding v6 to v7 migration guide (#2491) --------- Co-authored-by: Lidor Dafna <[email protected]> Co-authored-by: Inbal Tish <[email protected]> Co-authored-by: Miki Leib <[email protected]> Co-authored-by: Adi Mordo <[email protected]> Co-authored-by: Inbal Tish <[email protected]> Co-authored-by: Audrius Savickas <[email protected]> Co-authored-by: M-i-k-e-l <[email protected]>
Inbal-Tish
deleted the
v7_KeyboardAccessoryView_remove_iOSscrollBehavior_prop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
V7_KeyboardAccessoryView - remove 'iOSScrollBehavior' prop and 'iosScrollBehaviors' enum
Changelog
V7_KeyboardAccessoryView - remove 'iOSScrollBehavior' prop and 'iosScrollBehaviors' enum (use 'scrollBehavior' prop instead and pass it 'Keyboard.KeyboardAccessoryView.scrollBehaviors' )