Skip to content

V7_TabController - remove 'selectedIndex' prop #2481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

Inbal-Tish
Copy link
Collaborator

Description

TabController - remove 'selectedIndex' prop

Changelog

TabController - remove 'selectedIndex' prop (use 'initialIndex' instead)

@Inbal-Tish Inbal-Tish changed the base branch from master to v7 February 15, 2023 13:03
@Inbal-Tish Inbal-Tish requested a review from ethanshar February 15, 2023 13:03
@ethanshar ethanshar merged commit ed37af1 into v7 Feb 15, 2023
ethanshar added a commit that referenced this pull request Feb 16, 2023
* V7/ remove leftToggleHapticTrigger drawer (#2470)

* remove leftToggleHapticTrigger

* formatting

* Fader - FaderPosition enum remove LEFT and RIGHT cases

* V7 remove native WheelPicker (#2475)

* Remove native WheelPicker

* Remove WheelPickerDialog

* Remove WheelPickerPackage leftovers

* Remove PickerPackage(s)

* Missed one

* Remove 'style' prop from ColorPicker (#2480)

* v7_Picker (#2478)

* Migrate picker component

* Remove commented code

* Incubator Toast zIndex set to 100 as default when using Android (#2477)

* V7 primary colors (#2476)

* remove Colors.primary

* remove themeColors

* update test

* TabController - remove 'selectedIndex' prop (#2481)

* remove contentOnRight prop (#2473)

* V7 dark shadows (#2472)

* remove dark shadow presets

* update screen

* formatting

* deprecate imageSource of Avatar (#2471)

* KeyboardAwareListView - remove component (#2474)

* Remove some Skeleton props (#2482)

* Move moment to be optional dependency (#2485)

* V7_DateTimePicker (#2487)

* Migrate ChipsInput to Incubator ChipsInput (#2483)

* Migrate ChipsInput to Incubator ChipsInput

* removed old ChipsInput componenet

* Moved Incubator ChipsInput to components, fixed review notes

* V7/ ThemeManager (#2484)

* remove old theme keys and themeManager getters

* remove primaryColor from theme

* revert chipsInput change

---------

Co-authored-by: Ethan Sharabi <[email protected]>

* TabBar - remove component (#2467)

* v7_TextField (#2468)

* Enable text field migration

* Ignore/fix TS errors

* Move incubator TextField example screen to be the official screen

* Remove centered prop from migration since it is supported

* Remove transformer from migration list cause it is supported as formatter

* V7_KeyboardAccessoryView - remove 'iOSScrollBehavior' prop (#2469)

* KeyboardAccessoryView - remove 'iOSScrollBehavior' prop and 'iosScrollBehaviors' enum

* fix pr comments

* V7/ update colors docs (#2488)

* update colors docs

* improve docs

* add missing comma

* WheelPicker - move from incubator (#2486)

* Press is actually sync (#2459)

* Tests/Add testID to AnimatedScanner (#2458)

* add testID to AnimatedScanner

* update API

* Update src/components/animatedScanner/index.js

fix lint

---------

Co-authored-by: Inbal Tish <[email protected]>

* Re-export WheelPicker from Incubator and add a TODO to delete

* V7 - Upgrade typescript to latest version 4.9.5 and fix errors (#2490)

* Docs - adding v6 to v7 migration guide (#2491)

---------

Co-authored-by: Lidor Dafna <[email protected]>
Co-authored-by: Inbal Tish <[email protected]>
Co-authored-by: Miki Leib <[email protected]>
Co-authored-by: Adi Mordo <[email protected]>
Co-authored-by: Inbal Tish <[email protected]>
Co-authored-by: Audrius Savickas <[email protected]>
Co-authored-by: M-i-k-e-l <[email protected]>
@Inbal-Tish Inbal-Tish deleted the v7_TabController_remove_selectedIndex branch February 16, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants