V7 typescript #2490
V7 typescript #2490
Conversation
demo/src/screens/MenuStructure.js
Outdated
| @@ -175,10 +172,9 @@ export const navigationData = { | |||
| title: 'Incubator (Experimental)', | |||
| screens: [ | |||
| {title: 'Calendar', tags: 'calendar', screen: 'unicorn.components.IncubatorCalendarScreen'}, | |||
| {title: 'ChipsInput (New)', tags: 'chips input', screen: 'unicorn.components.IncubatorChipsInputScreen'}, | |||
| {title: 'ChipsInput', tags: 'chips input', screen: 'unicorn.components.ChipsInputScreen'}, | |||
There was a problem hiding this comment.
ChipsInput screen should move under 'form'
There was a problem hiding this comment.
Why is related to this PR? I didn't change there anything
There was a problem hiding this comment.
hmm I think it was because the PR was targeting master and not v7
| @@ -17,7 +17,7 @@ export class ButtonDriver extends ComponentDriver { | |||
| } | |||
|
|
|||
| isPressable = async () => { | |||
| if (this.exists()) { | |||
| if (await this.exists()) { | |||
There was a problem hiding this comment.
I think Miki just change the onPress to be sync as it actually is sync. Don't we need to remove the async instead?
There was a problem hiding this comment.
https://github.com/wix/react-native-ui-lib/pull/2459/files
It was merged after the Adi cut the version (I wasn't aware that we're cutting a version yesterday) so maybe we should include it in v7
There was a problem hiding this comment.
Were there changes in v6 before we cut the version?
There shouldn't be delta between last v6 and start of v7
@M-i-k-e-l ?
There was a problem hiding this comment.
@Inbal-Tish This fix is relevant. The isExists is async and we address it a sync function..
There was a problem hiding this comment.
As Inbal stated it looks like it was merged to master after we started working on v7.
There was a problem hiding this comment.
I don't see any delta.
Which change are you referring to exactly? why did we merged changes while working on v7?
anyway, do we need to cherry pick it to v7?
There was a problem hiding this comment.
I merged the PR since no one told me that we were cutting a version. The change is in the PR I added here
| @@ -11,7 +11,7 @@ export class TextDriver extends ComponentDriver { | |||
| } | |||
|
|
|||
| isPressable = async () => { | |||
| if (this.exists()) { | |||
| if (await this.exists()) { | |||
|
@ethanshar Wow, these are the only ts errors we had! Just one comment about onPress sync instead of async, but approved anyway |
* V7/ remove leftToggleHapticTrigger drawer (#2470) * remove leftToggleHapticTrigger * formatting * Fader - FaderPosition enum remove LEFT and RIGHT cases * V7 remove native WheelPicker (#2475) * Remove native WheelPicker * Remove WheelPickerDialog * Remove WheelPickerPackage leftovers * Remove PickerPackage(s) * Missed one * Remove 'style' prop from ColorPicker (#2480) * v7_Picker (#2478) * Migrate picker component * Remove commented code * Incubator Toast zIndex set to 100 as default when using Android (#2477) * V7 primary colors (#2476) * remove Colors.primary * remove themeColors * update test * TabController - remove 'selectedIndex' prop (#2481) * remove contentOnRight prop (#2473) * V7 dark shadows (#2472) * remove dark shadow presets * update screen * formatting * deprecate imageSource of Avatar (#2471) * KeyboardAwareListView - remove component (#2474) * Remove some Skeleton props (#2482) * Move moment to be optional dependency (#2485) * V7_DateTimePicker (#2487) * Migrate ChipsInput to Incubator ChipsInput (#2483) * Migrate ChipsInput to Incubator ChipsInput * removed old ChipsInput componenet * Moved Incubator ChipsInput to components, fixed review notes * V7/ ThemeManager (#2484) * remove old theme keys and themeManager getters * remove primaryColor from theme * revert chipsInput change --------- Co-authored-by: Ethan Sharabi <[email protected]> * TabBar - remove component (#2467) * v7_TextField (#2468) * Enable text field migration * Ignore/fix TS errors * Move incubator TextField example screen to be the official screen * Remove centered prop from migration since it is supported * Remove transformer from migration list cause it is supported as formatter * V7_KeyboardAccessoryView - remove 'iOSScrollBehavior' prop (#2469) * KeyboardAccessoryView - remove 'iOSScrollBehavior' prop and 'iosScrollBehaviors' enum * fix pr comments * V7/ update colors docs (#2488) * update colors docs * improve docs * add missing comma * WheelPicker - move from incubator (#2486) * Press is actually sync (#2459) * Tests/Add testID to AnimatedScanner (#2458) * add testID to AnimatedScanner * update API * Update src/components/animatedScanner/index.js fix lint --------- Co-authored-by: Inbal Tish <[email protected]> * Re-export WheelPicker from Incubator and add a TODO to delete * V7 - Upgrade typescript to latest version 4.9.5 and fix errors (#2490) * Docs - adding v6 to v7 migration guide (#2491) --------- Co-authored-by: Lidor Dafna <[email protected]> Co-authored-by: Inbal Tish <[email protected]> Co-authored-by: Miki Leib <[email protected]> Co-authored-by: Adi Mordo <[email protected]> Co-authored-by: Inbal Tish <[email protected]> Co-authored-by: Audrius Savickas <[email protected]> Co-authored-by: M-i-k-e-l <[email protected]>
Description
Upgrade typescript to version V7 4.9.5 and fix errors
Changelog
Upgrade typescript to version V7 4.9.5 and fix errors