convert three digit hex to six #976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Oct 14, 2020
ethanshar
reviewed
Oct 19, 2020
src/style/colors.ts
Outdated
Comment on lines
213
to
217
| function threeDigitHexToSix(value: string) { | ||
| return value.replace(/./g, '$&$&'); | ||
| const firstDigit = value[0]; | ||
| const secondDigit = value[1]; | ||
| const thirdDigit = value[2]; | ||
| return firstDigit.concat(firstDigit, secondDigit, secondDigit, thirdDigit, thirdDigit); |
There was a problem hiding this comment.
Why not just return value + value ?
There was a problem hiding this comment.
We need to double each letter:
threeDigitHexToSix(123) should return 112233 and not 123123
There was a problem hiding this comment.
You are completely right! my bad :(
In that case the regex solution is definitely preferable...
apologies for the trouble
ethanshar
approved these changes
Oct 23, 2020
M-i-k-e-l
added a commit
that referenced
this pull request
Oct 25, 2020
* master: Fix missed issue with migrating Picker API - PickerItem needs to retrieve the correct value format Add Slider testID (#999) Remove declaration of ref type on TouchableOpacity convert three digit hex to six (#976) Fix/text field right icon alignment (#997) migrate Switch to TS (#991) Move from KeyboardAwareListView to KeyboardAwareFlatList (#960) Update constants typings migrate ActionBar to TS (#987) Do not notify the user onPageChange for the fake page (fix autoscroll on Android bug) (#994) Add progress type for ProgressBarProps (#996) Fix generated JS files to include propTypes (#995) # Conflicts: # generatedTypes/components/touchableOpacity/index.d.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Colors.rgbareturned wrong values when getting 3 digit hex,I've added function to convert 3 digit hex to 6 digit hex inside
validateHexBug description: #946
Changelog
fix bug in
Colors.rgba