Skip to content

migrate Switch to TS #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 21, 2020
Merged

migrate Switch to TS #991

merged 4 commits into from
Oct 21, 2020

Conversation

lidord-wix
Copy link
Contributor

Changelog

Migration of Switch and SwitchScreen to typescript.

@lidord-wix lidord-wix requested a review from ethanshar October 19, 2020 14:37
@ethanshar ethanshar requested review from M-i-k-e-l and removed request for ethanshar October 19, 2020 15:53
@ethanshar ethanshar assigned M-i-k-e-l and unassigned ethanshar Oct 19, 2020
@lidord-wix lidord-wix requested a review from M-i-k-e-l October 20, 2020 11:20
Copy link
Collaborator

@M-i-k-e-l M-i-k-e-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style prop has the wrong type

@lidord-wix lidord-wix requested a review from M-i-k-e-l October 20, 2020 15:52
@M-i-k-e-l M-i-k-e-l merged commit 5554e43 into master Oct 21, 2020
M-i-k-e-l added a commit that referenced this pull request Oct 25, 2020
* master:
  Fix missed issue with migrating Picker API - PickerItem needs to retrieve the correct value format
  Add Slider testID (#999)
  Remove declaration of ref type on TouchableOpacity
  convert three digit hex to six (#976)
  Fix/text field right icon alignment (#997)
  migrate Switch to TS (#991)
  Move from KeyboardAwareListView to KeyboardAwareFlatList (#960)
  Update constants typings
  migrate ActionBar to TS (#987)
  Do not notify the user onPageChange for the fake page (fix autoscroll on Android bug) (#994)
  Add progress type for ProgressBarProps (#996)
  Fix generated JS files to include propTypes (#995)

# Conflicts:
#	generatedTypes/components/touchableOpacity/index.d.ts
@lidord-wix lidord-wix deleted the Infra/migrate_Switch_to_TS branch November 17, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants