migrate ActionBar to TS #987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Oct 19, 2020
Comment on lines
6
to
10
| const cameraSelected = require('../../assets/icons/cameraSelected.png'); | ||
| const video = require('../../assets/icons/video.png'); | ||
| const tags = require('../../assets/icons/tags.png'); | ||
| const collections = require('../../assets/icons/collections.png'); | ||
| const richText = require('../../assets/icons/richText.png'); |
There was a problem hiding this comment.
Why did you change imports to require?
There was a problem hiding this comment.
I saw we usually use require for assets..
Is import is better for this kind of usage?
There was a problem hiding this comment.
require is an es5 syntax
import is an es6 syntax
The advantage of require is that you can call it anywhere (anytime).
This is how we do "lazy loading" when requiring something at a specific point.
While imports always happen and are not lazy loaded
In this case when requiring at the top of the file it's equivalent to import
There was a problem hiding this comment.
Got you..
Changing to import :)
src/components/actionBar/index.tsx
Outdated
Comment on lines
17
to
44
| /** | ||
| * action bar height | ||
| */ | ||
| height: PropTypes.number, | ||
| height?: number, | ||
| /** | ||
| * action bar background color | ||
| */ | ||
| backgroundColor: PropTypes.string, | ||
| backgroundColor?: string, | ||
| /** | ||
| * actions for the action bar | ||
| */ | ||
| actions: PropTypes.arrayOf(PropTypes.shape(Button.propTypes)), | ||
| actions: ButtonPropTypes[], | ||
| /** | ||
| * should action be equally centered | ||
| */ | ||
| centered: PropTypes.bool, | ||
| centered?: boolean, | ||
| /** | ||
| * use safe area, in case action bar attached to the bottom (default: true) | ||
| */ | ||
| useSafeArea: PropTypes.bool, | ||
| useSafeArea?: boolean, | ||
| /** | ||
| * keep the action bar position relative instead of it absolute position | ||
| */ | ||
| keepRelative: PropTypes.bool, | ||
| keepRelative?: boolean, | ||
| /** | ||
| * style the action bar | ||
| */ | ||
| style: PropTypes.oneOfType([PropTypes.object, PropTypes.number, PropTypes.array]) | ||
| style?: ViewStyle ; |
There was a problem hiding this comment.
each type should end with semicolon
ethanshar
approved these changes
Oct 21, 2020
M-i-k-e-l
added a commit
that referenced
this pull request
Oct 25, 2020
* master: Fix missed issue with migrating Picker API - PickerItem needs to retrieve the correct value format Add Slider testID (#999) Remove declaration of ref type on TouchableOpacity convert three digit hex to six (#976) Fix/text field right icon alignment (#997) migrate Switch to TS (#991) Move from KeyboardAwareListView to KeyboardAwareFlatList (#960) Update constants typings migrate ActionBar to TS (#987) Do not notify the user onPageChange for the fake page (fix autoscroll on Android bug) (#994) Add progress type for ProgressBarProps (#996) Fix generated JS files to include propTypes (#995) # Conflicts: # generatedTypes/components/touchableOpacity/index.d.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Migration of ActionBar and ActionBarScreen to typescript.