[NUC472/M453] Support Bootloader and FlashIAP #4008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
reviewed
Mar 23, 2017
| }; | ||
|
|
||
| static const flash_algo_t flash_algo_config = { | ||
| // FIXME |
There was a problem hiding this comment.
what does FIXME mean in this file?
There was a problem hiding this comment.
Sorry, it's the comment in developing stage. Now, it's redundancy and I removed it.
c1728p9
approved these changes
Mar 23, 2017
sg-
suggested changes
Mar 29, 2017
There was a problem hiding this comment.
trng_api.c looks to have some stray tabs and formatting slips. Mind updating? https://docs.mbed.com/docs/mbed-os-handbook/en/latest/cont/code_style/
|
It's done to remove stray tabs to avoid formatting slips in |
|
/morph test |
0xc0170
approved these changes
Mar 30, 2017
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
1. Remove setting of not released register ICPCON 2. Enable FMC_APUEN to update APROM
sg-
approved these changes
Apr 6, 2017
|
/morph test-nightly |
1 similar comment
|
/morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
Double ready for merge 😄 |
aisair
pushed a commit
to aisair/mbed
that referenced
this pull request
Apr 30, 2024
Ports for Upcoming Targets Fixes and Changes 4008: [NUC472/M453] Support Bootloader and FlashIAP ARMmbed/mbed-os#4008 4102: Add SCL and SDA defs for I2C[0-2]; redefine I2C_[SCL,SDA] to I2C2 ARMmbed/mbed-os#4102 4118: STM32F4 Internal ADC channels rework ARMmbed/mbed-os#4118 4126: STM32F4 : remove SERIAL_TX and SERIAL_RX from available pins ARMmbed/mbed-os#4126 4148: Revert "STM32F4 Internal ADC channels rework" ARMmbed/mbed-os#4148 4152: STM32F4 Internal ADC channels rework ARMmbed/mbed-os#4152 4074: [Silicon Labs] Update pinout ARMmbed/mbed-os#4074 4133: U-BLOX_C030: Default XTAL is now 12MHz onboard. Option to use Debug 8MHz ARMmbed/mbed-os#4133 4142: EFM32: Fixed `pwmout_all_inactive` being inversed ARMmbed/mbed-os#4142 4016: [NRF5]: fix rtc overflow-while-set-timestamp issue ARMmbed/mbed-os#4016 4031: STM32 increase IAR heap size for big RAM targets ARMmbed/mbed-os#4031 4137: MCUXpresso: Update ARM linker files to eliminate reserving RAM for stack & heap ARMmbed/mbed-os#4137 4176: STM32L4 Internal ADC channels rework ARMmbed/mbed-os#4176 4154: STM32F7 Internal ADC channels rework ARMmbed/mbed-os#4154 4174: [NRF52840]: fix rtc overflow-while-set-timestamp issue ARMmbed/mbed-os#4174 4180: [UBLOX_C030] create target hierarchy for the specific versions of the C030 board ARMmbed/mbed-os#4180 4153: STM32F2: Internal ADC channels rework ARMmbed/mbed-os#4153
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR patches for the targets NuMaker-PFM-NUC472 and NuMaker-PFM-M453 and has the following modifications:
Verified OK by
mbed-os-example-bootloaderandmbed-os-example-bootloader-blinky.Also passed Greentea test on ARMCC, GCC and IAR, except
mbed-os-tests-mbed_hal-flash.mbed-os-tests-mbed_hal-flashfails due to test code bug itself. See the PR thread below:#3968
Attached the test report for reference.
M453_GCC_ARM_Test20170323.txt
M453_IAR_Test20170323.txt
M453_ARM_Test20170323.txt
NUC472_GCC_ARM_Test20170323.txt
NUC472_IAR_Test20170323.txt
NUC472_ARM_Test20170323.txt