Skip to content

STM32F4 Internal ADC channels rework #4152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2017
Merged

Conversation

jeromecoutant
Copy link
Collaborator

Description

Internal ADC pin are now out of PinMap_ADC array.

This PR is :

Status

READY

Internal ADC pin are now out of PinMap_ADC array.
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 11, 2017

cc @RobMeades

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 11, 2017

/morph test

@RobMeades
Copy link
Contributor

Ref. UBLOX_C030, if it compiles I guess it's good as we're not using the ADCs at the moment.

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1876

Example Build failed!

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 11, 2017

restarting test CI as the example failures do not look like valid in this case?

/morph test

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 11, 2017

@marhil01 @tommikas Can you help with Jenkins CI failure (all recent mbed-os PR are red)

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1877

All builds and test passed!

@tommikas
Copy link
Contributor

@0xc0170 The failing tests have now been disabled while we figure out why they're failing.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 11, 2017

@0xc0170 The failing tests have now been disabled while we figure out why they're failing.

Thanks !

@0xc0170 0xc0170 removed the needs: CI label Apr 11, 2017
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 11, 2017

@jeromecoutant I noticed, this is going to the revert branch. I was wondering how this is on top of it, missed that detail previously (please specify destination branch and the intention so its not overlooked, would help).

@0xc0170 0xc0170 changed the base branch from revert-4118-PR_REWORK_INTERNAL_ADC_F4 to master April 11, 2017 12:39
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 11, 2017

I changed the base branch, as we merged the revert commit.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 11, 2017

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1878

All builds and test passed!

@sg- sg- merged commit 87610e7 into ARMmbed:master Apr 19, 2017
@jeromecoutant jeromecoutant deleted the PR_ADC_F4_NEW branch September 27, 2017 09:58
aisair pushed a commit to aisair/mbed that referenced this pull request Apr 30, 2024
Ports for Upcoming Targets


Fixes and Changes

4008: [NUC472/M453] Support Bootloader and FlashIAP ARMmbed/mbed-os#4008
4102: Add SCL and SDA defs for I2C[0-2]; redefine I2C_[SCL,SDA] to I2C2 ARMmbed/mbed-os#4102
4118: STM32F4 Internal ADC channels rework ARMmbed/mbed-os#4118
4126: STM32F4 : remove SERIAL_TX and SERIAL_RX from available pins ARMmbed/mbed-os#4126
4148: Revert "STM32F4 Internal ADC channels rework" ARMmbed/mbed-os#4148
4152: STM32F4 Internal ADC channels rework ARMmbed/mbed-os#4152
4074: [Silicon Labs] Update pinout ARMmbed/mbed-os#4074
4133: U-BLOX_C030: Default XTAL is now 12MHz onboard. Option to use Debug 8MHz ARMmbed/mbed-os#4133
4142: EFM32: Fixed `pwmout_all_inactive` being inversed ARMmbed/mbed-os#4142
4016: [NRF5]: fix rtc overflow-while-set-timestamp issue ARMmbed/mbed-os#4016
4031: STM32 increase IAR heap size for big RAM targets ARMmbed/mbed-os#4031
4137: MCUXpresso: Update ARM linker files to eliminate reserving RAM for stack & heap ARMmbed/mbed-os#4137
4176: STM32L4 Internal ADC channels rework ARMmbed/mbed-os#4176
4154: STM32F7 Internal ADC channels rework ARMmbed/mbed-os#4154
4174: [NRF52840]:  fix rtc overflow-while-set-timestamp issue ARMmbed/mbed-os#4174
4180: [UBLOX_C030] create target hierarchy for the specific versions of the C030 board ARMmbed/mbed-os#4180
4153: STM32F2: Internal ADC channels rework ARMmbed/mbed-os#4153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants