Skip to content

STM32F2: Internal ADC channels rework #4153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2017

Conversation

jeromecoutant
Copy link
Collaborator

Description

Internal ADC pin are now out of PinMap_ADC array

CI shield level 0 tests are now OK

Status

READY

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 12, 2017

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1893

Build failed!

@bridadan
Copy link
Contributor

@jeromecoutant Looks like a build failure for the NUCLEO_F207ZG across all toolchains:

        Compile [ 73.6%]: analogin_api.c
        [DEBUG] Compile: /home/jenkins/gcc_arm_6/gcc-arm-none-eabi-6-2017-q1-update/bin/arm-none-eabi-gcc -std=gnu99 -c -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -fmessage-length=0 -fno-exceptions -fno-builtin -ffunction-sections -fdata-sections -funsigned-char -MMD -fno-delete-null-pointer-checks -fomit-frame-pointer -Os -mcpu=cortex-m3 -mthumb -DDEVICE_SPI=1 -DTARGET_NUCLEO_F207ZG -DMBED_BUILD_TIMESTAMP=1492011127.73 -DFEATURE_LWIP=1 -D__MBED__=1 -DDEVICE_I2CSLAVE=1 -DTARGET_LIKE_MBED -DDEVICE_PORTOUT=1 -DUSBHOST_OTHER -DDEVICE_PORTINOUT=1 -D__MBED_CMSIS_RTOS_CM -DTARGET_STM32F2 -DDEVICE_RTC=1 -DTOOLCHAIN_object -DDEVICE_SERIAL_ASYNCH=1 -D__CMSIS_RTOS -DTOOLCHAIN_GCC -DDEVICE_I2C_ASYNCH=1 -DTARGET_LIKE_CORTEX_M3 -DTARGET_CORTEX_M -DARM_MATH_CM3 -DDEVICE_ANALOGOUT=1 -DTARGET_UVISOR_UNSUPPORTED -DTARGET_M3 -DDEVICE_SERIAL=1 -DMBED_HEAP_STATS_ENABLED=1 -DDEVICE_INTERRUPTIN=1 -DDEVICE_I2C=1 -DTRANSACTION_QUEUE_SIZE_SPI=2 -D__CORTEX_M3 -DDEVICE_STDIO_MESSAGES=1 -DTARGET_FF_MORPHO -DDEVICE_SPI_ASYNCH=1 -DTARGET_STM32F207ZG -DTARGET_FF_ARDUINO -DTARGET_RELEASE -DTARGET_STM -DDEVICE_SERIAL_FC=1 -DMBED_STACK_STATS_ENABLED=1 -DDEVICE_PORTIN=1 -DDEVICE_SLEEP=1 -DTOOLCHAIN_GCC_ARM -DDEVICE_CAN=1 -DDEVICE_SPISLAVE=1 -DDEVICE_ANALOGIN=1 -DDEVICE_PWMOUT=1 @/home/jenkins/mbed_jenkins/workspace/bm_wrap/1986/mbed-os/BUILD/tests/NUCLEO_F207ZG/GCC_ARM/.includes_b08f26a6554a738f4a781c321d1be2a8.txt -include /home/jenkins/mbed_jenkins/workspace/bm_wrap/1986/mbed-os/BUILD/tests/NUCLEO_F207ZG/GCC_ARM/mbed_config.h -MD -MF /home/jenkins/mbed_jenkins/workspace/bm_wrap/1986/mbed-os/BUILD/tests/NUCLEO_F207ZG/GCC_ARM/targets/TARGET_STM/TARGET_STM32F2/analogin_api.d -o /home/jenkins/mbed_jenkins/workspace/bm_wrap/1986/mbed-os/BUILD/tests/NUCLEO_F207ZG/GCC_ARM/targets/TARGET_STM/TARGET_STM32F2/analogin_api.o /home/jenkins/mbed_jenkins/workspace/bm_wrap/1986/mbed-os/targets/TARGET_STM/TARGET_STM32F2/analogin_api.c
        [Error] analogin_api.c@68,52: 'PinMap_ADC_Internal' undeclared (first use in this function)
        [DEBUG] Return: 1
        [DEBUG] Output: /home/jenkins/mbed_jenkins/workspace/bm_wrap/1986/mbed-os/targets/TARGET_STM/TARGET_STM32F2/analogin_api.c: In function 'analogin_init':
        [DEBUG] Output: /home/jenkins/mbed_jenkins/workspace/bm_wrap/1986/mbed-os/targets/TARGET_STM/TARGET_STM32F2/analogin_api.c:68:52: error: 'PinMap_ADC_Internal' undeclared (first use in this function)
        [DEBUG] Output:          obj->adc = (ADCName)pinmap_peripheral(pin, PinMap_ADC_Internal);
        [DEBUG] Output:                                                     ^~~~~~~~~~~~~~~~~~~
        [DEBUG] Output: /home/jenkins/mbed_jenkins/workspace/bm_wrap/1986/mbed-os/targets/TARGET_STM/TARGET_STM32F2/analogin_api.c:68:52: note: each undeclared identifier is reported only once for each function it appears in

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 20, 2017

@jeromecoutant Bump

@jeromecoutant
Copy link
Collaborator Author

Hi
As #4152 has been merged, can you please restart CI ?

@bridadan
Copy link
Contributor

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 50

All builds and test passed!

@adbridge adbridge merged commit 1c77628 into ARMmbed:master Apr 21, 2017
@jeromecoutant jeromecoutant deleted the PR_AF2_LEVEL0 branch April 21, 2017 13:12
aisair pushed a commit to aisair/mbed that referenced this pull request Apr 30, 2024
Ports for Upcoming Targets


Fixes and Changes

4008: [NUC472/M453] Support Bootloader and FlashIAP ARMmbed/mbed-os#4008
4102: Add SCL and SDA defs for I2C[0-2]; redefine I2C_[SCL,SDA] to I2C2 ARMmbed/mbed-os#4102
4118: STM32F4 Internal ADC channels rework ARMmbed/mbed-os#4118
4126: STM32F4 : remove SERIAL_TX and SERIAL_RX from available pins ARMmbed/mbed-os#4126
4148: Revert "STM32F4 Internal ADC channels rework" ARMmbed/mbed-os#4148
4152: STM32F4 Internal ADC channels rework ARMmbed/mbed-os#4152
4074: [Silicon Labs] Update pinout ARMmbed/mbed-os#4074
4133: U-BLOX_C030: Default XTAL is now 12MHz onboard. Option to use Debug 8MHz ARMmbed/mbed-os#4133
4142: EFM32: Fixed `pwmout_all_inactive` being inversed ARMmbed/mbed-os#4142
4016: [NRF5]: fix rtc overflow-while-set-timestamp issue ARMmbed/mbed-os#4016
4031: STM32 increase IAR heap size for big RAM targets ARMmbed/mbed-os#4031
4137: MCUXpresso: Update ARM linker files to eliminate reserving RAM for stack & heap ARMmbed/mbed-os#4137
4176: STM32L4 Internal ADC channels rework ARMmbed/mbed-os#4176
4154: STM32F7 Internal ADC channels rework ARMmbed/mbed-os#4154
4174: [NRF52840]:  fix rtc overflow-while-set-timestamp issue ARMmbed/mbed-os#4174
4180: [UBLOX_C030] create target hierarchy for the specific versions of the C030 board ARMmbed/mbed-os#4180
4153: STM32F2: Internal ADC channels rework ARMmbed/mbed-os#4153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants